search

nov / fb_graph

This gem doesn't support FB Graph API v2.0+. Please use fb_graph2 gem instead.
MIT License
1.04k stars 191 forks source link

Hometown can be string #358

Closed gazay closed 10 years ago

gazay commented 10 years ago

Hometown in facebook can be entered just as a string. It's lead to exception. You can check it by executing following code: FbGraph::User.fetch 'alexeyushka111'. I've provided pull request for fb mock with new private json file which can help to test it. After it'll be merged I'll add here spec for this case.

What do you think about this fix? Maybe there is a better way?

nov commented 10 years ago

For some reason, travis seems unstable. I'll look at the travis fail, so please ignore it fail for now.

gazay commented 10 years ago

I've updated commits

gazay commented 10 years ago

Also I have checked other values, which can be entered as a string in musical/band pages and they're seems fine and working. Maybe in different categories of pages could be this kind of errors, but for now I don't have time to check them all.

gazay commented 10 years ago

Thank you for fast merge =) Very helpful gem

nov commented 10 years ago

ok, travis green. https://travis-ci.org/nov/fb_graph/builds/23204907

and understood other error cases. thanks!

nov commented 10 years ago

It's the best time to work on private projects in Japan ;-)