search

nov / fb_graph

This gem doesn't support FB Graph API v2.0+. Please use fb_graph2 gem instead.
MIT License
1.04k stars 191 forks source link

Update v2 API calls to 2.2 #390

Closed raelik closed 9 years ago

raelik commented 9 years ago

Facebook has deprecated API versions before v2.2. Updated the gem version as well to ensure anyone still using this gem gets this update.

jdejong commented 9 years ago

Please merge this as soon as possible. We had to go to a forked version to keep production up and running for our application.

nov commented 9 years ago

can you try fb_graph2 gem?

jdejong commented 9 years ago

It currently doesn't have any of the Ad or Marketing API's as far as I can tell. I know Facebook's release schedule is going to be different for the Graph API and the Marketing API now, and it may make sense to split the functionality into a separate gem at this point but I didn't know what your plan was. If your going to try and bring it into fb_graph2 then we can help with some of that since we use most of the marketing API ourselves. Otherwise we will create a separate gem for the marketing api.

Thoughts?

Jonathan De Jong Partner [Description: Description: cid:image001.jpg@01C8B1D4.FB23A720] jdejong@sparknettech.commailto:jdejong@sparknettech.com http://www.sparknettech.comhttp://www.sparknettech.com/ 999 Old Eagle School Road * Suite 121 * Wayne, PA * 19087 800.893.2650tel:800.893.2650.p * 610.329.9510tel:610.329.9510.c * 800.893.6075tel:800.893.6075.f

From: Nov Matake notifications@github.com<mailto:notifications@github.com> Reply-To: nov/fb_graph reply@reply.github.com<mailto:reply@reply.github.com> Date: Saturday, March 14, 2015 at 5:26 AM To: nov/fb_graph fb_graph@noreply.github.com<mailto:fb_graph@noreply.github.com> Cc: Jonathan De Jong jdejong@sparknettech.com<mailto:jdejong@sparknettech.com> Subject: Re: [fb_graph] Update v2 API calls to 2.2 (#390)

can you try fb_graph2 gem?

Reply to this email directly or view it on GitHubhttps://github.com/nov/fb_graph/pull/390#issuecomment-80208110.

nov commented 9 years ago

To be honest, I don't know well about Ads APIs. All code around Ads APIs are from contributors...

nov commented 9 years ago

BTW, v2.0 isn't deprecated yet. https://developers.facebook.com/docs/apps/changelog

jdejong commented 9 years ago

It is for Marketing API. They only give you 90 days after they publish a release now on that API.

Jonathan De Jong Partner [Description: Description: cid:image001.jpg@01C8B1D4.FB23A720] jdejong@sparknettech.commailto:jdejong@sparknettech.com http://www.sparknettech.comhttp://www.sparknettech.com/ 999 Old Eagle School Road * Suite 121 * Wayne, PA * 19087 800.893.2650tel:800.893.2650.p * 610.329.9510tel:610.329.9510.c * 800.893.6075tel:800.893.6075.f

From: Nov Matake notifications@github.com<mailto:notifications@github.com> Reply-To: nov/fb_graph reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, March 17, 2015 at 9:53 AM To: nov/fb_graph fb_graph@noreply.github.com<mailto:fb_graph@noreply.github.com> Cc: Jonathan De Jong jdejong@sparknettech.com<mailto:jdejong@sparknettech.com> Subject: Re: [fb_graph] Update v2 API calls to 2.2 (#390)

BTW, v2.0 isn't deprecated yet. https://developers.facebook.com/docs/apps/changelog

Reply to this email directly or view it on GitHubhttps://github.com/nov/fb_graph/pull/390#issuecomment-82363021.

nov commented 9 years ago

Then probably what you need is something like this. https://github.com/nov/fb_graph/commit/e2dc6370f6b3d5fe3b13e048b142295cbd38dc6a

I can't guarantee this gem works fine with v2.2 or later though.. If this is OK for you, I'll release new version.

jdejong commented 9 years ago

I ended up forking and changed the /lib/fb_graph.rb and we have been running on that.

https://github.com/jdejong/fb_graph/blob/master/lib/fb_graph.rb

The bigger thing is there are a bunch of new Marketing API's which we have created as local model's in our App that ideally we are going to put into a Gem. If your ok with it we can start working on adding it to fb_graph2, otherwise we will create a separate gem for the marketing api only.

Jonathan De Jong Partner [Description: Description: cid:image001.jpg@01C8B1D4.FB23A720] jdejong@sparknettech.commailto:jdejong@sparknettech.com http://www.sparknettech.comhttp://www.sparknettech.com/ 999 Old Eagle School Road * Suite 121 * Wayne, PA * 19087 800.893.2650tel:800.893.2650.p * 610.329.9510tel:610.329.9510.c * 800.893.6075tel:800.893.6075.f

From: Nov Matake notifications@github.com<mailto:notifications@github.com> Reply-To: nov/fb_graph reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, March 17, 2015 at 10:22 AM To: nov/fb_graph fb_graph@noreply.github.com<mailto:fb_graph@noreply.github.com> Cc: Jonathan De Jong jdejong@sparknettech.com<mailto:jdejong@sparknettech.com> Subject: Re: [fb_graph] Update v2 API calls to 2.2 (#390)

Then probably what you need is something like this. e2dc637https://github.com/nov/fb_graph/commit/e2dc6370f6b3d5fe3b13e048b142295cbd38dc6a

I can't guarantee this gem works fine with v2.2 or later though.. If this is OK for you, I'll release new version.

Reply to this email directly or view it on GitHubhttps://github.com/nov/fb_graph/pull/390#issuecomment-82380659.

nov commented 9 years ago

OK, then I close this issue. I think it's better to have a separate gem for Ads API.