nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.35k stars 198 forks source link

[FEAT]: Please have TMDB multimedia information in Traditional Chinese version #1129

Open hellotaeyeon0214 opened 7 months ago

hellotaeyeon0214 commented 7 months ago

Description

Please have TMDB multimedia information in Traditional Chinese version

Additional information

No response

courville commented 7 months ago

First, note that you can chose the scraping language in the nova settings under the scrape section for movies and series and you can manually set it.

Now you need to find the right item for Traditional Chinese.

There I can use some help: according to https://developer.themoviedb.org/reference/configuration-languages, the full list of supported languages are in the form of two letters code ISO639-1:

aa|ab|ae|af|ak|am|an|ar|as|av|ay|az|ba|be|bg|bi|bm|bn|bo|br|bs|ca|ce|ch|cn|co|cr|cs|cu|cv|cy|da|de|dv|dz|ee|el|en|eo|es|et|eu|fa|ff|fi|fj|fo|fr|fy|ga|gd|gl|gn|gu|gv|ha|he|hi|ho|hr|ht|hu|hy|hz|ia|id|ie|ig|ii|ik|io|is|it|iu|ja|jv|ka|kg|ki|kj|kk|kl|km|kn|ko|kr|ks|ku|kv|kw|ky|la|lb|lg|li|ln|lo|lt|lu|lv|mg|mh|mi|mk|ml|mn|mr|ms|mt|my|na|nb|nd|ne|ng|nl|nn|no|nr|nv|ny|oc|oj|om|or|os|pa|pi|pl|ps|pt|qu|rm|rn|ro|ru|rw|sa|sc|sd|se|sg|sh|si|sk|sl|sm|sn|so|sq|sr|ss|st|su|sv|sw|ta|te|tg|th|ti|tk|tl|tn|to|tr|ts|tt|tw|ty|ug|uk|ur|uz|ve|vi|vo|wa|wo|xh|yi|yo|za|zh|zu

You see that you do not find the zh-cn (Chinese) and zh-tw (Traditional Chinese) classical ones.

Referring https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes for the zoology of ISO639 codes, I figured that cn and zh are related to Chinese language as a whole.

"Funny" thing is that cn is not a ISO639-1 code. After some search to treat these exceptions, I made the correspondance to map cn to the 3 letters code ISO639-3 yue which is Cantonese. Please forgive my ignorance but I associated Cantonese in my mind to Traditional Chinese (or another non existing ISO639-1 code zt) but I left the translation of yue to the Android system and thus I have no clue how it appears in the nova scrape language setting menu.

Could you tell me if my interpretation is correct: i.e. cn=yue? And if I need to force cn naming to Traditional Chinese (for now it should appear as Cantonese in the language list)?

Note that, for the little story non related to TMDb, opensubtitles uses the non standard zht code for Traditional Chinese that I mapped manually to the Traditional Chinese string as an exception.

courville commented 7 months ago

Please confirm you agree with analysis and fix (cn is Traditional Chinese) by selecting Cantonese as language in scape section and verifying that indeed it results in Traditional Chinese movies/shows descriptions.

courville commented 7 months ago

@hellotaeyeon0214 please provide feedback on https://github.com/nova-video-player/aos-AVP/releases/tag/v6.2.62

hellotaeyeon0214 commented 6 months ago

@hellotaeyeon0214請在https://github.com/nova-video-player/aos-AVP/releases/tag/v6.2.62上提供回饋

(Use google translate traditional Chinese to English, sorry)

I selected Traditional Chinese and re-captured it, but the poster changed to the original language and the introduction narrative was in English.

I have entered the TMDB website and selected unreleased movies as an example.

Cantonese (mostly used in Hong Kong and Macau) HK

Traditional Chinese (used in Taiwan) TW

(Both are similar but not quite the same)

The subtitles are in Traditional Chinese but the subtitles in the video are in Simplified Chinese.

courville commented 4 weeks ago

@hellotaeyeon0214 sorry for the late reply on this. Thanks for your help in getting the right mapping between Traditional and Simplified Chinese. Let's focus on movie descriptions. In TMDB there are two language settings in the API:

Is this correct? I interpret your previous comment as that it is not correct and it should be the opposite.

courville commented 4 weeks ago

OK I think cn gets me only english which is wrong. Though tmdb API tells me there is only cn (Cantonese) and zh (Mandarin) there is obviously more supported. On tmdb interface I get zh-cn, zh-tw, zh-hk, zh-sg. Could someone native tell me which I should use with which proper english translation (for now I have only two: Simplified Chinese and Traditional Chinese).

courville commented 4 weeks ago

Please provide feedback on 6.2.92 and tell me if I need to add more Chinese language variants (with proper english naming translations).

yu4nyu commented 4 weeks ago

Propose to have the mapping as below: zh-cn, Chinese (Mainland China) zh-tw, Chinese (Taiwan) zh-hk, Chinese (Hong Kong)

courville commented 4 weeks ago

Thank you @yu4nyu, this makes better sense to me. Will do the changes. On a separate topic regarding opensubtitles https://api.opensubtitles.com/api/v1/infos/languages, this is the mapping I propose:

courville commented 4 weeks ago

My final takeways.