search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.38k stars 201 forks source link

[Bug]: Random names are listed for subtitles in subtitles list #1144

Closed JJD2K closed 4 months ago

JJD2K commented 7 months ago

Problem description

In the subtitles selection list the SRT subtitles sometimes get listed with strange random 3 letter names. For example: god, Ntb, Atm ...

Steps to reproduce the issue

I do not see any particular reason for this so far, but it seems to happen in movies with integrated subtitles.

Expected behavior

The subtitle extension should be listed - SRT, SUB etc.

Your phone/tablet/androidTV model

TCL C845

Operating system version

Google TV 12

Application version and app store

Latest from Google Playstore

Additional system information

This happens on all my devices and is not related to the hardware.

Debug logs

No response

courville commented 4 months ago

Should be fixed now in 6.2.72 (I think). Now logic for identifying language is based on subtracting from sub filename the video filename without extension with a "." added which would lead to SRT if result is empty or the language inferred from the resulting string (e.g. video.mkv + video.srt -> SRT, video.mkv + video.eng.srt -> English or video.eng.HI.srt -> Engligh (HI) for hearing impaired). Please reopen if it is not the case.

JJD2K commented 4 months ago

@courville Thank you for your fix. This was a minor issue which does not impact usage. I am looking forward to an important fix: https://github.com/nova-video-player/aos-AVP/issues/1177 Cheers.