nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.5k stars 201 forks source link

Trakt connection not possible - no internet connection #254

Closed Textator closed 2 years ago

Textator commented 4 years ago

Nova isn't able to sign into Trakt. The white window starts to open, then nova states "no internet connection".

I clear cache, data, reinstalled. Different phone. No luck.

Using latest beta.

courville commented 4 years ago

I have just retested the beta and I can login to trakt on two phones and on two androitv. I saw that you reported the issue earlier as well but I cannot reproduce it. Can you please disclose the phone and Android version?

Textator commented 4 years ago

Of course: LG G5 h850 ROM RR-O-v6.2.1-20190117-h850-Unofficial, Android Oreo

But it worked before.

kozmo2k4 commented 4 years ago

Same issue when trying to activate Trakt login. Latest Play Store install, v 4.2. Asus TF300T, AOSP 7.1.2 (TimDuru ROM), and Nexus 7 (2013), LineaageOS 16. Same issue. Pop-up says "No internet connection" Screenshot_20200125-164609

Ilithy commented 4 years ago

Hi, I just tested the connection to Trakt, I get an error too (Error 504 gateway time-out), I provide a screenshot

Tested from a smartphone:

Oneplus 6 (build: ONEPLUS A6000_22_191214) Snapdragon processor Android 10 - OxygenOS 10.3.0

Nova Video Player : Downloaded from the Play Store version: 1.0-20200124.1845

Screenshot_20200126-203049

courville commented 4 years ago

Hi, I just tested the connection to Trakt, I get an error too (Error 504 gateway time-out), I provide a screenshot

there it is because trakt is experiencing an issue and it should be back hopefully soon...

Ilithy commented 4 years ago

Okay, thank you, sir. Sorry to bother you

courville commented 4 years ago

@Ilithy no problem at all

fadern commented 4 years ago

Hi, I just wanted to say that I still have this issue. I dont experience any problems using trakt api from other apps (like OSMC). SONY: KD-55X9005C

PS. Thank you for this great app. Ive been using it for years. :-)

Textator commented 4 years ago

same with me, still. Like @fadern & @kozmo2k4 All other apps or website work.

courville commented 4 years ago

The "No Internet connection" comes from OAuthData code being null in TraktSigninPreference.java line 69 (nothing to do with no Internet). Now question is why?

bronnel commented 4 years ago

This issue still exist on latest version ...

Textator commented 4 years ago

@courville Thanks, yes, of course there' internet connection. I'm using a replacement phone at the moment, no problems there. Any way to find out, what the matter is?

courville commented 4 years ago

Sorry for the late reply. I will rework this part of the code that obviously behaves strangely on some devices and instrument more debugging to find what goes wrong. I will request your contribution to collect the logs. Stay tuned.

mschumacher69 commented 4 years ago

@courville while you're reworking this part of the code, please look into signing into trakt via Google SSO from Android TV, this failed when I tried to sign in to trakt with Google from Android TV, I had to sign in with username and password.

It said something about couldn't verify the browser or something like that when I tried to sign in with Google.

Thanks

courville commented 4 years ago

@Textator @fadern @kozmo2k4 sorry for the late reply on the topic. Since I am in the blind for this issue, I have generated an apk with more verbose debugs that can be found here: https://drive.google.com/open?id=1FLKh9hAEP6AagA_4Iv0nUf2mPYs_82K0 Could you please reproduce the issue with this one and get me some adb logs (i.e. https://github.com/nova-video-player/aos-AVP/wiki/Debugging)?

bronnel commented 4 years ago

@courville , Hello here is a what happens when I try to login on my LG V30 stock android oreo 8.0

https://www.youtube.com/watch?v=XVhlNtrqFwA&feature=youtu.be

here is logcat using the apk you posted above https://pastebin.com/BgFLBBrH

courville commented 4 years ago

@bronnel thanks for the pastebin, I clearly see the error:

2020-05-03 17:01:06.933 26640-26640/? D/OAuthDialog: onReceivedError API23+
2020-05-03 17:01:06.933 26640-26640/? D/TraktSigninDialogPreference: onClick: data.code null!
2020-05-03 17:01:06.990 26640-26640/? W/OAuthDialog: onReceivedError: error is Tk@a1967d

However I failed to provide the right description (my fault). I modified the code to be more verbose hopefully than "Tk@a1967d" . Could you please do the same process and send me the logcat again with the following apk: https://drive.google.com/open?id=1cC0Y6-Gn4DpGWMDQkR3TNTR4F-0dIoYz Sorry for the inconvenience...

bronnel commented 4 years ago

@courville thanks for troubleshooting this the new description says something like this "ERR_CONNECTION_REFUSED" here is another logcat in verbose mode https://pastebin.com/xbwbvbnU

courville commented 4 years ago

Yes you are right W/OAuthDialog: onReceivedError: error code is -6, description net::ERR_CONNECTION_REFUSED. Now I need to figure out why is causing this...

bronnel commented 4 years ago

@courville I'm availabe for help if you need just let me know.

bronnel commented 4 years ago

@courville just to let you know , I tested the original archos vdeo player that I purchased from play store , Trakt sign in still works there without problem , so you can check out the source code of archos and see the difference for yourself

courville commented 4 years ago

The problem is that Archos code target an API level that is far below the one targeted by nova that required some rework. But I will recheck for being sure.

courville commented 4 years ago

@bronnel OK here we go again, could you please check this new apk with more logs and one idea that could cause the connectivity error https://drive.google.com/open?id=1RQMXuuJCsCKwOtl4TQfJ9nw_cJmRX4BB ? Please pastebin the logcat too. Thanks for helping progressing on the issue.

bronnel commented 4 years ago

@courville , It is my pleasure to help anytime here is the Logcat

Update I just discovered something , my device is rooted and adaway installed , it is an adblocking software , I disabled adaway and rebooted my phone and boom trakt sign in working fine. so maybe other users also have ad blocking app installed?

courville commented 4 years ago

@bronnel wow, interesting discovery. This explains why, I was not able to figure out the issue.

courville commented 4 years ago

@Textator @fadern @kozmo2k4 please check @bronnel discovery and check if you are not in this case (rooted rom with adaway or equivalent).

fadern commented 4 years ago

@courville I'm using a Sony android tv and it's running a stock rom, not rooted. I have a pihole that acts as my dns but i havent seen that it blocks any trakt domains and i'm able to use trakt from other devices that are on my network and are using the same pihole/dns.

courville commented 4 years ago

@fadern thanks for the feedback, could you please use the apk provided there https://drive.google.com/open?id=1RQMXuuJCsCKwOtl4TQfJ9nw_cJmRX4BB with extended logs to reproduce the issue and get me some adb logs (i.e. https://github.com/nova-video-player/aos-AVP/wiki/Debugging)?

Textator commented 4 years ago

@courville sorry that I didn't reply earlier. Strange times. As I'm using still a replacemnt phone I can't debug any further. BUT: of course I used adaway on my rooted custom rom... 2nd BUT: that "no internet" issue just popped up out of nothing, it worked before on that same rom. 3rd BUT: thinking about it, I changed the block lists in adaway a while ago. Maybe that interferes. Oh dear. I'm sorry if that was the reason and apologise for causing trouble without checking that first. And huge thank you for your work! I'll check as soon as I can. @bronnel since I can't use my rooted phone yet, do you have any issues when disabling adaway / adblock?

bronnel commented 4 years ago

@Textator I currently don't have any issues at all , the trakt sign in with NOVA only work when adaway is completely disabled , I tried to whitelist trakt when enabled but that didn't work , BTW I noticed adaway blocks some DNS stuff , I also found that the logs I provided above contain some DNS blocking stuff when trying to login to trakt.

The good news is you can re-enable Adaway after successful login to trakt , it will stay logged in and no I did not have any problem syncing with trakt ( I verified that).

The strange thing is I have many other movie and tv show tracking apps like moviemate and seriesmate, when adaway is enabled I can easily login to trakt so this issue happens only with NOVA I don't know why. I guess those apps use a different sign in procedure than the one NOVA uses, maybe that's why. because I noticed when I tried to login to trakt on moviemate app (Adaway enabled BTW) it asked me to open chrome and then login, but NOVA has a different behavior (not asking to open chrome)

Textator commented 4 years ago

@bronnel Thanks for the info. Good to know that adaway has just to be disabled to sign in. Nice workaround ;-) I was able to sign into trakt.tv via browser (just log into the website) while adaway was enabled, so same here. It's just NOVA.

@courville I can bassically confirm the behaviour bronnel wrote about.

So, what to do? I'm ready to send logs, once I have my rooted phone assembled again, which will take while. On the other hand I'm so far satisfied with the work around of just disabling adaway while signing in. Shall we close the issue or keep it open so far? In any case it might be helpful to put the workaround somewhere so people affected can just disable any adblocker while signing in.

Update: @bronnel , I can confirm now, that disabling adaway solves the problem. Thanks again!

dhlavaty commented 3 years ago

Same problem on AndroidTV. Cannot sign in to trakt. It displays "no internet connection" message.

After reading this thread, I found out that I had to whitelist these domains on my Pi-hole: static.criteo.net www.google-analytics.com stats.g.doubleclick.net

AndroidTV version 9 on TCL 55C815 ; Nova Video Player 5.15.13-20201203.2027

courville commented 3 years ago

@dhlavaty thanks you for pointing out this is very useful information: I will put it in the howto.

gggirlgeek commented 3 years ago

Same problem on AndroidTV. Cannot sign in to trakt. It displays "no internet connection" message.

After reading this thread, I found out that I had to whitelist these domains on my Pi-hole: static.criteo.net www.google-analytics.com stats.g.doubleclick.net

AndroidTV version 9 on TCL 55C815 ; Nova Video Player 5.15.13-20201203.2027

doubclick? Seriously? Grrrrrrrr. That would allow many many ads to get through your firewall -- way too many. So this would be a deal-breaker for me.

Textator commented 3 years ago

Same problem on AndroidTV. Cannot sign in to trakt. It displays "no internet connection" message. After reading this thread, I found out that I had to whitelist these domains on my Pi-hole: static.criteo.net www.google-analytics.com stats.g.doubleclick.net AndroidTV version 9 on TCL 55C815 ; Nova Video Player 5.15.13-20201203.2027

doubclick? Seriously? Grrrrrrrr. That would allow many many ads to get through your firewall -- way too many. So this would be a deal-breaker for me.

I dididn't check which domains would've to be whitelisted - but: you just need to diasble firewall /adblock / pi-hole while siging in into trakt.tv. After that you can block again. We'll I can.

courville commented 2 years ago

Closing due to inactivity and possibly prior solving. Please reopen an issue if needed.

HDGuy commented 1 year ago

Still having this problem on 2019 Nvidia Shield, changed DNS a few times and nothing seems to solve it.

courville commented 1 year ago

@HDGuy, just tested on my side and it works (on my phone). Are you using any adblocker (adblock, pihole, etc.)? This could interfere (at least with all similar issues).

HDGuy commented 1 year ago

I was initially using AdGuard DNS address but then I switched to my ISPs (FIOS), rebooted everything, router. Shield, etc, but it’s still doing it. Tried Google’s DNS, no difference. I’m getting that error.

Textator commented 1 year ago

Did you reboot the device where Nova is running on after changing DNS?

Maogxer commented 6 months ago

2024,.05.13 the same issue.

chrickers commented 4 months ago

This is still not working on my AndroidTV