search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.4k stars 201 forks source link

Subtitles can not load #281

Open JJD2K opened 4 years ago

JJD2K commented 4 years ago
  1. Load a tv show with some integrated subtitle
  2. Stop Nova and go and add a subtitle file in the tv show location with same name as tv show video file.
  3. Start NOVA - subtitle is displayed on info page, but not in selection list while video is playing.

I reported a similar issue before regarding "Select on storage" I guess these are related. I think Nova caches somehow things and there is absolutely no way to load the added subtitle - only restartin tv maybe will work - restarting Nova does not help.

Please take a look at subtitles code as this is a common situation and is really annoying. Thank you.

JJD2K commented 4 years ago

P.S please take a look also at "Select from storage" code as it never worked properly. Thank you.

JJD2K commented 4 years ago

The same file and subtitles load just fine in ARCHOS

courville commented 4 years ago

Where are your files? Local storage, SMB share or HDD connected via USB? How do you put your subs? Difference with Archos could be also explained by Archos Video Player using a very old target API level.

JJD2K commented 4 years ago

files are ### ON SMB I have made a dumb typo here by writing NO.

Files are located on a SMB share.

JJD2K commented 4 years ago

Something is wrong with subtitles in Nova...even if I use "download subtitles" and if a file is found - again it is displayed in the INFO page and not listed in the subtitles list in the menu and can not be loaded. The files are there in the folder

JJD2K commented 4 years ago

Another strange thing is that both in ARCHOS and NOVA the subtitle track is listed as DTS while the file is SRT. Today I tried to load the subs file in NOVA and now it is loading - had this issue many times before.

JJD2K commented 4 years ago

Ok, I tested this further and the issue today appeared on Archos too. I guess it is not a regression it is an old bug. Yesterday Archos was loading the subs today not. As far as I see this usually happens on files that have integrated subs - something happens when mixing integrated and external subs. If you have any clues or test versions I will be glad to test - just let me know.

JJD2K commented 4 years ago

I can not see any pattern for this issue - it works perfectly on some files with integrated subs and not in others. I do not see anything in the file name too.... Could it be some sort of cache that makes NOVA ignore loading the subs...I see nothing related to subs in the xml files?

JJD2K commented 4 years ago

Ok, this is some sort of cache problem I guess. There were 3 files: video.name.srt video.name.1.srt video.name.lng.srt - downloaded by NOV

I removed the last 2 files and kept only the first one. Restarting nova, rescanning, deleting the .xml file, removing and adding back to the library - nothing makes any difference - it keeps displaying the 3 files in the INFO page while now there is only video.name.srt in the video folder.

JJD2K commented 4 years ago

I did another test. Copied the file with the subs to a new subfolder and renamed it to a shorter file name - no difference. I guess it has to do with the fact that the file has 28 integrated subtitles in it. Maybe they get too much?

courville commented 4 years ago

Thanks for the testing. I guess that there is indeed a max number of subs limit that I need to investigate.

courville commented 4 years ago

Could you privately share the file name with the 28 integrated subs causing issue so that I can retrieve and test?

JJD2K commented 1 year ago

PLEASE FIX THIS - I SENT YOU SAMPLES This is so annoying.

Korb commented 2 months ago

I confirm that if there is an srt-file on the internal memory of the smartphone or on the memory card in the folder with the video file, it is automatically recognized as subtitles of the video being played. However, the same files located on SMB-storage are processed differently by the application: the video file is played, but the subtitles are not displayed, just as there is no way to specify the file that should be connected as subtitles to the current video.

NOVA Video Player 6.2.90 (602090) f-droid
SMB-server @ Microsoft Windows 10.0.19045.4651

OS version: Funtouch OS 14
Model: Vivo T1 4G (V2153)
Hardware version: MP_0.1
Build number: PD22010F_EX_A_14.2.7.12.W20
Baseband version: S.HA.1.1.c2-00054-DIVAR_GENSP_PACK-1.29062.88
Kernel version: 4.19.157-perf+, 1 Wed Jun 5 10:25:33 CST 2024
Compile time: 5 Jun 2024 05:20:41
Android security update: 1 June 2024
Google Play system update: 1 May 2024