search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.52k stars 201 forks source link

AV1 videos with grain synthesis do not playback #410

Open natis1 opened 3 years ago

natis1 commented 3 years ago

To encode a video with grain synthesis: aomenc --denoise-noise-level=[1-50]. Playing it back in aos-AVP does not work and just shows a black screen.

the backend, dav1d does support it and the video plays back perfectly in vlc, although you can disable it in dav1d with --filmgrain 0

courville commented 3 years ago

Thanks for reporting the issue. Would you have a sample available to share? We are using dav1d 0.8.1 with ffmpeg 4.3.1. I will check if this is related.

natis1 commented 3 years ago

It looks like it might not actually be grain synthesis related but instead may have something to do with keyframe-filtering=2, "filter with overlay." This file plays on my phone in vlc and on my pc with mpv, but does not want to work in aos-avp: 10bit.zip

courville commented 3 years ago

Thanks for sharing. I am interested to use ffplay to check if it plays well. For now nova forces ffmpeg/dav1d for AV1 but could rely on the phone hw/sw own codecs. Could you please tell me what phone/android version you are using?

natis1 commented 3 years ago

I’ve tested it on a Lenovo Z6 Pro with stock Android 10, which has a Snapdragon 855 CPU and on a ZTE Axon 7 with Android 9 and a Snapdragon 820. Neither has hardware decoding support for av1

courville commented 3 years ago

What I meant is that recent version of Android provide AV1 software decoding support and applications could use the codec provided by the platform instead of embedded dav1d one in nova. Nova choose to force upon using its own software codecs instead of the platform ones in case platform ones are software and not hardware based. This could explain the difference. I will make a version of nova removing this change for dav1d and check your file when I get a chance.

Pentaphon commented 3 years ago

All @courville can do is update to dav1d 0.8.2 and ffmpeg 4.3.2 which came out since the last post.