search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.17k stars 190 forks source link

Add PGS subtitle support #47

Open courville opened 5 years ago

kennethpangky commented 5 years ago

Hi, anyone looking at this?

courville commented 5 years ago

Hi, anyone looking at this?

unfortunately not yet.

DrGogu commented 3 years ago

Hope the developer works on this. Makes Nova Player useless to me as I watch a lot of foreign movies! Almost every other player plays PGS subtitles, but they are not as good as Nova when it comes to compatibility with video codecs. Thanks a lot!

courville commented 3 years ago

The project is opensource, contributions are welcome. You can download subs via the app too.

DrGogu commented 3 years ago

Thank you. I would appreciate it if you fixed this for us, a vital feature! The thing is, although I can download subtitles, the embedded ones are perfectly synced.

You live in France I think?, I like French movies and I use subtitles to watch them.

courville commented 3 years ago

For clarification: it is not a fix, it is a development to be carried out. I would love it too...

DrGogu commented 3 years ago

For clarification: it is not a fix, it is a development to be carried out. I would love it too...

Since you are the main developer I was hoping you are working on it.. :(

But thanks a lot for your quick replies.

DrGogu commented 3 years ago

Any chance this is made as a sticky on the first page so other developers can see it? It is such an important function and the request seems hidden here. Thanks.

Pentaphon commented 3 years ago

Any chance this is made as a sticky on the first page so other developers can see it? It is such an important function and the request seems hidden here. Thanks.

PGS is supported on Exoplayer, which Nova will be adding in v7, so look out for that in the future.

DrGogu commented 3 years ago

We are at v5 now.. any idea when v7 will be coming?

Thanks.

On Sat, Mar 6, 2021, 12:04 PM Pentaphon notifications@github.com wrote:

Any chance this is made as a sticky on the first page so other developers can see it? It is such an important function and the request seems hidden here. Thanks.

PGS is supported on Exoplayer, which Nova will be adding in v7, so look out for that in the future.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nova-video-player/aos-AVP/issues/47#issuecomment-792001456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSVAFS3EOQ2DZ4OTCETSE3TCJVD3ANCNFSM4GWWXUCQ .

Pentaphon commented 3 years ago

We are at v5 now.. any idea when v7 will be coming? Thanks.

He is working on v6 and I believe another person is working on v7 at the same time. V7 is a bigger project so that is further out. You can follow the progress at this issue.

https://github.com/nova-video-player/aos-AVP/issues/401

The dev has stated that test builds are coming but not to expect them soon. I've already asked him to let us know via the releases page or that issue when test builds are ready to be downloaded, so we should just be patient.

HDGuy commented 1 year ago

Any update on this? Nova is my chosen video player and I can’t watch most of my anime with it.

DrGogu commented 1 year ago

I gave up on it.  I use Kodi. On Oct 29, 2022, at 10:51 AM, HDGuy @.***> wrote: Any update on this? Nova is my chosen video player and I can’t watch most of my anime with it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

HDGuy commented 1 year ago

Kodi has microstutters on the Shield, that’s why I’m using Nova.

DrGogu commented 1 year ago

VLC is another option. On Oct 30, 2022, at 9:30 AM, HDGuy @.***> wrote: Kodi has microstutters on the Shield, that’s why I’m using Nova.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

HDGuy commented 1 year ago

On Sun, Oct 30, 2022 at 11:43 AM DrGogu @.***> wrote:

VLC is another option. On Oct 30, 2022, at 9:30 AM, HDGuy @.***> wrote: Kodi has microstutters on the Shield, that’s why I’m using Nova.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/nova-video-player/aos-AVP/issues/47#issuecomment-1296287595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQ2WG3ATM4G5W6O5I5OBSDWF2JSFANCNFSM4GWWXUCQ . You are receiving this because you

I’m just using Nova as the front end with JustPlayer as the actual player. JP is ExoPlayer based, plays pretty much everything and has PGS sub support.

Pentaphon commented 1 year ago

I’m just using Nova as the front end with JustPlayer as the actual player. JP is ExoPlayer based, plays pretty much everything and has PGS sub support.

@DrGogu this is a good solution if you're still willing to check it out. https://github.com/moneytoo/Player and use this as external player.

HDGuy commented 1 year ago

Main issue with doing it this way is having to manually mark everything in Nova as “watched” after. Not a big deal, only takes a few secs.

Also, JustPlayer’s audio is out of sync when you launch it this way, I have to manually rewind it it every time to get it in sync again.

That said I’m hoping whenever ExoPlayer is finally integrated into Nova it should fix a lot of problems. It’s unfortunate Kodi is the only other non-server based player on Android TV that does indexing but has microstutters on the Shield.

Pentaphon commented 1 year ago

For clarification: it is not a fix, it is a development to be carried out. I would love it too...

It could also be done by supporting mpv instead of forking ffmpeg.

courville commented 1 year ago

@Pentaphon, ffmpeg has pgs support. I "just" need to replug it into https://github.com/nova-video-player/aos-avos It is in my todo https://github.com/nova-video-player/aos-AVP/projects/1

Pentaphon commented 7 months ago

ffmpeg has pgs support. I "just" need to replug it

Any progress on this with 6.1? it was a big jump from 4.4.x

courville commented 7 months ago

No progress for now unfortunately.