search

nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.33k stars 198 forks source link

[FEAT]: Add support for AFR service from tvquickactions #563

Open marbor1 opened 2 years ago

marbor1 commented 2 years ago

Description

Add support for AFR service from tvquickactions: https://tvdevinfo.com/tvquickactions/afr/ Tvquickactionsapp has added AFR service for amlogic devices that don't have native AFR. It already works with VIMU, SmartTubeNext and Tivimate.

Additional information

https://play.google.com/store/apps/details?id=dev.vodik7.tvquickactions https://tvdevinfo.com/tvquickactions/contact/

courville commented 2 years ago

Why do you need automatic frame rate? There a an option to tune the refresh rate according to content in nova. Do you have videos with a variable frame rate?

phhusson commented 2 years ago

I tested that app.

So what it does is:

  1. Despite the name "AFR", it doesn't detect the refresh rate (or it simply didn't trigger for me yet?), user sets refresh rate on its own via a shortcut (though anyway NOVA does know refresh rate)
  2. it registers itself as an accessibility app, launch Settings app, and click on the refresh rate, like the user would do, but simulating the user.
  3. It is so error prone, that it actually fails on my STB (Freebox Player Pop)

Now, I checked how the integration has been done by SmartTubeNext, and it's pretty easy, it's just sending a broadcast intent: https://github.com/yuliskov/SmartTubeNext/blob/master/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/TvQuickActions.java