nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.35k stars 200 forks source link

[FEAT]: Option to disable DolbyVision #800

Closed coolllman closed 1 year ago

coolllman commented 1 year ago

Description

I have sheld tv pro 2019 and its support dolby vision, but my tv support only hdr10, and when i play hdr+dolby mix mkv, hdr don't work, nova player the best, and only this problem don't make me quit from vimu player (in this player, this option work great), thank you

P.s. sorry for my bad english Update: test all mkv with hdr+dolby in kodi, hdr works good, but nova player better, any chance to fix it?

Additional information

No response

courville commented 1 year ago

Looking at https://github.com/google/ExoPlayer/issues/9794, it seems that nova could have an option to disable dolby vision codec by rejecting them in CodecDiscovery so that isCodecTypeSupported would report in avos stream_parser_ffmpeg:_parse_format that it needs to switch to another codec.

Could be useful for TVs not supporting DOVI. Perhaps DOVI could be disabled too at platform level in global Android settings on some platforms.

coolllman commented 1 year ago

Wow, its great))

courville commented 1 year ago

@coolllman, I just plugged by shield 2019 (not pro) and in order to get DOVI you need to specifically request this display mode in the shield Android "Settings > Device Preferences > Display & Sound > Advanced display settings > Custom display mode and select any mode labelled “Dolby Vision Ready”." When not selecting a DoVi display mode, my TV stays with normal colors without DoVi triggered.

Now this is for bluray dolby vision content (typically movies) but for tv shows I get funky green/purple colors and exoplayer trick will not help here.

Can you please provide the full video file name (including codec/resolution/DV etc.) on which it does not work in nova and it works with vimu player?

coolllman commented 1 year ago

Its about 20 mkvs, all dolby vision + hdr10 mix mkv, when tv don't have dovi, its goes to hdr10, in kodi and vimu when plays this mkv, my lg tv switch to hdr, in nova play, tv not switch to hdr and stays in sdr. In vimu if i enable dolby vision option, tv don't switch tv to hdr the same as nova, disable dolby vision setting in vimu and tv switch to hdr10. Sample: https://disk.yandex.kz/i/8x7WPHUjXMmclA

courville commented 1 year ago

TODO: fix avos throwing an exception while calling CodecDiscovery in avos:android_codec:acodecs_is_type_supported.

courville commented 1 year ago

@coolllman thanks for sharing the samples, once the code is complete, I will give it a try. Sample shared is DoVi two layers (el = extended layer in ffprobe) thus there is hope. Method proposed will not work with single layer DoVi files.

coolllman commented 1 year ago

Courville big thank you for your hard work and awesome media player!

courville commented 1 year ago

OK tested to work on the shield. Will be there in next release.

coolllman commented 1 year ago

Thank you, will wait next release.

courville commented 1 year ago

Pre-release to test available here https://github.com/nova-video-player/aos-AVP/releases/tag/v6.0.94

coolllman commented 1 year ago

Thank you very much, all work great!