nova-video-player / aos-AVP

NOVA opeN sOurce Video plAyer: main repository to build them all
Apache License 2.0
3.41k stars 200 forks source link

[Bug]: Recent changes in Kodi 20.1 made Nova unable to connect to its DLNA/UPNP server #842

Open Pentaphon opened 1 year ago

Pentaphon commented 1 year ago

Problem description

Due to recent changes in Kodi 20.1, Nova is no longer able to connect to Kodi 20.1's UPNP/DLNA server.

Steps to reproduce the issue

1) Clean Install Nova 6.1.1 2) Install Kodi 20.1 on any compatible device and share media over UPNP/DLNA according to https://kodi.wiki/view/Settings/Services/UPnP_DLNA#Share_my_libraries 3) Connect to the Kodi UPNP/DLNA share over the network, go through any folders that are in front of the main folder. Once you get to the main folder with videos, Nova reports "An Error Occurred" and a spinning animation.

This used to work fine on previous versions of Nova and Kodi, but not anymore.

Expected behavior

You should be able to connect to Kodi 20.1's UPNP/DLNA shares successfully and play videos without issue.

Your phone/tablet/androidTV model

Onn 4K

Operating system version

Android 10

Application version and app store

6.1.1 from Github

Additional system information

Other DLNA devices were able to connect to Kodi 20.1's shares, including a Samsung TV, but not any device running Nova 6.1.1

Debug logs

N/A reproducible

courville commented 1 year ago

Ack, seems to be a change in kodi. It still works with minidlna though. The longrun solution is to migrate from EOL https://github.com/4thline/cling to https://github.com/jupnp/jupnp or declare that UPnP is evil and opt for modern network share protocols.

Pentaphon commented 1 year ago

The longrun solution is to migrate from EOL https://github.com/4thline/cling to https://github.com/jupnp/jupnp or declare that UPnP is evil and opt for modern network share protocols.

I would definitely prioritize fixing the SMB speed issue by migrating to smbj over migrating from cling to jupnp. I think a lot of people have moved on from UPNP since it first became popular to stream media from a home share and went to SMB or FTP.

courville commented 8 months ago

@Pentaphon, I know it has been a while but with the help of jupnp devs, I managed to get an experimental nova release with jupnp instead of EOL cling. Could you let me know if it works for you? It is available here https://github.com/nova-video-player/aos-AVP/releases/tag/v6.2.56 Note that I still strongly recommend to use SMB for nova (or webdavs).

Pentaphon commented 8 months ago

@courville always happy to help! With Kodi as a DLNA server, I get what seems to be perfect connectivity. The info is scraped, the video plays just fine and even scrubs to another point in the video quickly, but then when I back out to play another video, I cannot connect to it and it shows me this message.

2

I then have to close Nova and restart it to connect to a video again. Once I try to play a 2nd video, I can't connect to it and get that message.

Also, I get the following weirdly long video info when connecting to a share via UPNP on Kodi. I blurred out the filename to keep from having any issues with Github's copyright rules, if any.

1

So sadly, no reliable playback when trying to play more than 1 video with .56. I can only play 1 video via Kodi before it fails to connect until I do a restart, play another video and then again, unable to connect to a 2nd video.

I'll keep testing any builds you have coming. Thanks for revamping all these share libraries.

courville commented 8 months ago

@Pentaphon, thanks for the feedback and testing: seems that I will need to install kodi's DNLA server :-(