[Bug]: Libraries getting lost on Amazon Fire devices

ghost commented 1 year ago

Problem description

After initial scraping (SMBv1 share on Apple Time Capsule), both Movies and TV Shows display correctly. However, if browsing another app on the Fire device and returning to Nova Player, libraries are gone. I have to exit Nova or press 'Home', wait a couple of minutes, then launch Nova again, and the libraries will appear again. 'Recently Played' and 'Recently Added' also sometimes appear, sometimes disappear.

v6.0.67 was the last version to work correctly on FireCube 4K Gen2. v6.0.65 and above work inconsistently on FireStick 4K Max.

Have done a complete factory reset on the FireStick 4K Max, and clean-installed Nova (v6.0.65 and above) and same problem.

Steps to reproduce the issue

1) Setup SMBv1 share on Nova 2) Wait until initial scrape. Libraries populated correctly. 3) Play any movie or tv show. 4) Return until exit from Nova and on OS home screen. 5) Wait a few minutes or use any other app. 6) Launch Nova.

At this point, Movies and TV Shows display generic icons and no movies or tv shows appear.

7) Return until exit from Nova and on OS home screen. 8) Wait a few minutes or use any other app. 9) Launch Nova.

At this point, Movies and TV Shows display populated icons and movies and tv shows fully appear.

If I repeat the same steps again (exit, wait, launch), then libraries are gone again, etc., etc. This behavior cycles.

I have changed Initial Scan on App Startup on and off to no effect.

Cleared cache and data to no avail.

Expected behavior

Libraries should stay populated.

Your phone/tablet/androidTV model

Firecube 4K Gen2, Firestick 4k Max

Operating system version

Fire OS 7.6.2.4

Application version and app store

v6.0.97 from Amazon App Store

Additional system information

v6.0.67 was the last version to work correctly on FireCube 4K Gen2. v6.0.65 and above work inconsistently on FireStick 4K Max. Haven't tried earlier versions.

Debug logs

No response

ghost commented 1 year ago

@courville

v6.1.2 (20230320.2258) on:

a) Firestick 4K Max (Fire OS 7.6.2.4 PS7624/3338) Wifi works correctly, except for the initial scrape generic icons issue. b) Firecube 4K Gen2 (Fire OS 7.6.2.4 PS7624/3337) Wired does not work correctly, i.e.: fails library, recents and icon tests.

Please let me know if you need any further info, logs, dbs, etc.

Thanks!

ghost commented 1 year ago

Update:

With "Re-scan when opening the application" set to "Yes":

Did a few random cycles (non-chronometered) and failed by the 3rd try (no pause on Home), i.e.: Recents gone, generic icons back, but libraries populated. Upon returning from Movies libraries, Recents populated, but generic icons remain.

A few more random cycles and failed again upon relaunch from Home OS screen (no pause).

Have stopped any further random tests at this point.

courville commented 1 year ago

@Molasar49 a big thank you about all your tests. Sad to see that we still have the issue with Firecube 4K Gen2 . Let me process all your inputs and start providing a clue.

courville commented 1 year ago

@Molasar49, it is frustrating that somehow I am not able to reproduce the issue you are having and I am sorry that I need to use you to troubleshoot this. Somehow, I am not yet fully convinced that the issue lies in the loaders. It is strange as well that we got a temporary release working and that the latest one is not.

Note that icons for video boxes are generated at the end after all the loaders are finished and the video lines are populated: they should appear correctly if you wait long enough. However if the library does not appear populated, they will not be regenerated: this is a symptom that something is wrong.

I have added more logs in the builds and I will need you to capture logcat logs only for nova using this specific command for linux/macos adb shell 'logcat --pid=$(pidof -s org.courville.nova)' or adb shell "logcat --pid=$(pidof -s org.courville.nova)" most probably for windows (previous logs sent where somehow not exploitable fully unfortunately). Note that nova needs to be running to launch the logcat (it will output previous logs of the process). Do not hesitate to ping me if you need help on this way of catching logs.

There are 3 builds to test (yes sorry it is a lot):

TEST1 which is the same as before (i.e. current v6.1.2 and it should fail) i.e. no custom executor for VideoLoader and ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(5200)); for VideosSelectionLoader and no throttling of loaders
TEST2 which has custom executor ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(5200)); both for VideoLoader and VideosSelectionLoader and still no throttling of loaders
TEST3 no custom executor and no throttling in VideoLoader and VideosSelectionLoader

Thanks again for all the testing and time dedicated to help on this issue.

ghost commented 1 year ago

@courville No problem!

I will initiate testing of these versions in a few minutes starting on Firecube and then on Firestick. I will post observations on the fly and send logcats as I go.

ghost commented 1 year ago

TEST1 Commencing trial runs v6.1.2 (20230321.2341) on Firecube 4K Gen2 Wired.

With "Re-scan when opening the application" set to "No":

1) Uninstalled previous version. 2) Installed TEST1 version. 3) Launched. 4) Initialed logcat capture as per above instructions. 5) Initial scraping in progress. 6) Initial scape done. Without doing anything, Recently Added populated. 7) Movies and TV Shows icons generic. Waiting 1 minute without doing anything. 8) 1m elapsed. Generic icons still displayed. 9) 2m elapsed. Still generic icons. 10) 3m elapsed. Still generic icons. 11) 4m elapsed. Still generic icons. a) Will now enter Movies library... Empty. Return. Generic icons still displayed. b) Will now enter TV Shows library... Empty. Return. Generic icons still displayed. 12) Will now perform cycle Exit->Home (no pause)->Relaunch... a) Recently Added gone. Generic icons on both libraries. b) Movies library empty. c) TV Shows library empty. 13) Exit->Home (1m pause)->Relaunch a) Recently Added gone. b) Movies and TV Shows Icons customized. c) Movies library populated. d) TV Shows populated. 14) Played movie for a bit. Return. a) Recently Added now populated. b) Recently Played now populated (1 movie). 15) Exit->Home (no pause)->Relaunch a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons generic. d) Movies library populated. e) TV Shows library populated. f) Both Movies and TV Shows icons still generic. 16) Exit->Home (5s pause)->Relaunch a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 17) Exit->Home (10s pause)->Relaunch a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 18) Exit->Home (15s pause)->Relaunch a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 19) Exit->Home (30s pause)->Relaunch a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 20) Exit->Home (1m pause)->Relaunch a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 21) Exit->Home (3m pause)->Relaunch a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 22) Exit->Home (6m pause)->Relaunch a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty.

At this point, sending log via email.

ghost commented 1 year ago

TEST1 Commencing trial runs v6.1.2 (20230321.2341) on Firecube 4K Gen2 Wired.

With "Re-scan when opening the application" set to "Yes":

1) Changed above setting. Exit->Home (no pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 2) Exit->Home (5s pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 3) Exit->Home (10s pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 4) Exit->Home (15s pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 5) Exit->Home (30s pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated. 6) Exit->Home (1m pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 7) Exit->Home (3m pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. 8) Exit->Home (6m pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Both Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty.

At this point, sending log via email.

ghost commented 1 year ago

1) Uninstalling v6.1.2 (20230321.2341) on Firecube 4K Gen2 Wired in preparation for TEST2. 2) Installed TEST2. Launch. Preferences>About shows v6.1.2 (20230321.2347) 3) Start logcat capture. 4) Initial scape started. a) Recently Added appears, but blank icons. Have noticed this populates correctly later on by itself. b) Recently Added populated by itself. 5) Initial scrape finished. a) Movies library icon generic. b) TV Shows library icon generic. 6) Waiting... a) 2.5m have elapsed. Screensaver kicked in (got distracted). Hit Return to exit from screensaver... b) Movies library icon customized. c) TV Shows library icon customized. e) Movies library populated. f) TV Shows populated. 7) Played movie for a bit. Return. a) Recently Played now populated (1 movie). 8) Exit->Home (no pause)->Relaunch a) Recently Added populated. b) Recently Played populated. b) Movies and TV Shows Icons customized. c) Movies library populated. d) TV Shows populated. 9) Exit->Home (5s pause)->Relaunch a) All correct! 10) Exit->Home (10s pause)->Relaunch a) All correct! 11) Exit->Home (15s pause)->Relaunch a) All correct! 12) Exit->Home (30s pause)->Relaunch a) All correct! 13) Exit->Home (1m pause)->Relaunch a) All correct! 14) Exit->Home (3m pause)->Relaunch a) All correct! 15) Exit->Home (6m pause)->Relaunch a) All correct!

At this point, sending log via email.

ghost commented 1 year ago

TEST2 Commencing trial runs v6.1.2 (20230321.2347) on Firecube 4K Gen2 Wired.

With "Re-scan when opening the application" set to "Yes":

1) Changed above setting. Exit->Home (no pause)->Relaunch. a) All correct! 2) Exit->Home (5s pause)->Relaunch a) All correct! 3) Exit->Home (10s pause)->Relaunch a) All correct! 4) Exit->Home (15s pause)->Relaunch a) All correct! 5) Exit->Home (30s pause)->Relaunch a) All correct! 6) Exit->Home (1m pause)->Relaunch a) All correct! 7) Exit->Home (3m pause)->Relaunch a) All correct! 8) Exit->Home (6m pause)->Relaunch a) All correct!

Clear winner. At this point, sending log via email.

ghost commented 1 year ago

1) Uninstalling v6.1.2 (20230321.2347) on Firecube 4K Gen2 Wired in preparation for TEST3. 2) Disabling screensaver. 3) Installed TEST3. Launch. Preferences>About shows v6.1.2 (20230321.2344) 4) Start logcat capture. 5) Initial scape started. a) Recently Added appears, but blank icons. Have noticed this populates correctly later on by itself. b) Recently Added populated by itself. 6) Initial scrape finished. a) Movies library icon generic. b) TV Shows library icon generic. 7) Waiting... a) 5m have lapsed. Still seeing Movies and TV Shows generic icons. 8) Entering Movies library. a) Populated. Return. b) Movies library still showing generic icon. 9) Entering TV Shows library. a) Populated. Return. b) TV Shows library still showing generic icon. 10) Exit->Home (no pause)->Relaunch a) Recently Added populated. b) Movies library icon customized. c) TV Shows library icon customized. e) Movies library populated. f) TV Shows populated. 11) Played movie for a bit. Return. a) Recently Played now populated (1 movie). 12) Exit->Home (no pause)->Relaunch a) All correct! 13) Exit->Home (5s pause)->Relaunch a) All correct! 14) Exit->Home (10s pause)->Relaunch a) All correct! 15) Exit->Home (15s pause)->Relaunch a) All correct! 16) Exit->Home (30s pause)->Relaunch a) All correct! 17) Exit->Home (1m pause)->Relaunch a) All correct! 18) Exit->Home (3m pause)->Relaunch a) All correct! 19) At about 1.5m into the 6m pause test, adb returned "read: unexpected EOF!" a) Sending logcat via email at this point. 20) Exit->Home (6m pause)->Relaunch a) All correct!

ghost commented 1 year ago

TEST3 Commencing trial runs v6.1.2 (20230321.2344) on Firecube 4K Gen2 Wired.

With "Re-scan when opening the application" set to "Yes":

1) Changed above setting. Exit->Home (no pause)->Relaunch. a) All correct! 2) Exit->Home (5s pause)->Relaunch. a) All correct! 3) Exit->Home (10s pause)->Relaunch. a) All correct! 4) Exit->Home (15s pause)->Relaunch. a) All correct! 5) Exit->Home (30s pause)->Relaunch. a) All correct! 6) Exit->Home (1m pause)->Relaunch. a) All correct! 7) Exit->Home (3m pause)->Relaunch. a) All correct! 8) Exit->Home (6m pause)->Relaunch. a) All correct!

Seems like a winner too. At this point, sending log via email.

ghost commented 1 year ago

@courville Will continue to conduct same tests for all versions on Firestick 4K Max tomorrow (it's 9:10 p.m. here local time) and post back.

courville commented 1 year ago

OK thanks for the tremendous testing. Unfortunately the logs and not providing hints on the cause of the issue: I will check on my side how I can improve. However what I take from your tests, is that:

always at first app scrape starting from completely empty media library at the end the video box icons are not updated (after it is ok)
TEST1 show the non populated library issue
TEST2 and TEST3 are winners This means that this is indeed a custom loader issue: using same custom ThreadPoolExecutor in VideoLoader and VideosSelectionLoader works but not a different one, and no custom ThreadPoolExecutor works too.

I need to chew on this. It definitively helps.

ghost commented 1 year ago

@courville Will continue to conduct same tests for all versions on Firestick 4K Max tomorrow (it's 9:10 p.m. here local time) and post back.

ghost commented 1 year ago

@courville About to initiate all tests on Firestick 4K Max. Will post and send logs as I go.

ghost commented 1 year ago

TEST1 Commencing trial runs v6.1.2 (20230321.2341) on Firestick 4K Max Wifi.

With "Re-scan when opening the application" set to "No":

1) Uninstalled previous version. 2) Installed TEST1 version. 3) Launched. 4) Initialed logcat capture as per above instructions. 5) Screensaver disabled. 6) Initial scape started. a) Recently Added appears, but blank icons. Have noticed this populates correctly later on by itself. b) Recently Added populated by itself. 7) Initial scrape finished. a) Movies library icon generic. b) TV Shows library icon generic. 8) Waiting... a) 3m have elapsed. b) Movies library icon generic. c) TV Shows library icon generic. e) Movies library populated. f) TV Shows populated. 9) Played movie for a bit. Return. a) Recently Played now populated (1 movie). 10) Exit->Home (no pause)->Relaunch a) Recently Added populated. b) Recently Played populated. b) Movies and TV Shows Icons generic. c) Movies library empty. d) TV Shows empty.

courville commented 1 year ago

You can do a lighter pass to confirm conclusions of above tests.

ghost commented 1 year ago

@courville Can you please clarify? You want me to perform swifter tests to spot pass or fail?

ghost commented 1 year ago

@courville If I understood corrently, have now proceeded to perform random cycles and can confirm TEST1 fails. Sending logs now.

ghost commented 1 year ago

Logs sent.

Proceeding to TEST2 on Firestick 4K Max Wifi...

ghost commented 1 year ago

Installed TEST2 on Firestick 4K Max. Started log capture and expediting test batteries to confirm PASS or FAIL.

Will report back.

ghost commented 1 year ago

TEST2 passes all quick tests, with and without Re-scan at startup set, except initial library icon refresh (needs 1 cycle to update). Sending logs now...

ghost commented 1 year ago

Logs sent.

Proceeding with TEST3 on Firestick 4K Max Wifi.

Will report back when finished.

ghost commented 1 year ago

@courville TEST3 passes all quick tests (with and without Re-scan at app start set), except library icons initial refresh (needs 1 cycle to update).

Sending logs now...

ghost commented 1 year ago

@courville Please let me know if you need any further info, dbs, logcats, etc.

courville commented 1 year ago

@Molasar49 thx for the testing and logcat! TEST2+TEST3 are thus ok on both firetv units. I have a viable release now and concrete evidence of where is the problem thanks to you.

ghost commented 1 year ago

@courville My pleasure! Please let me know if I can be of further assistance. It's no problem at all!

courville commented 1 year ago

See https://github.com/nova-video-player/aos-Video/commit/e04fc2b60d6db09b6482f2a47fbf689f986fe6fa

courville commented 1 year ago

@Molasar49, I think I made up my mind on the final tweaking (I hope). Here is the resulting pre-release nova-TEST4.apk If you could validate quickly if this is a winner on your side too, it would secure a final fix for your issue and ultimately close this issue. Thx in advance for your help.

ghost commented 1 year ago

@courville Initiating quick tests on Firecube 4K Gen2 Wired with TEST4.

Preferences>About shows v6.1.2. (20230324.2012).

Initiating tests without capturing logs. Will report back when done...

We just had the first "mini fail" here... Since Movies and TV Shows icons were not updating by themselves after the initial scrape, I did a standard, non-pause cycle:

1) (Return->Home (no pause)->Relaunch). a) Recently Added gone (populated by itself during the initial scrape). b) Movies and TV Shows empty.

2) Did another cycle: (Return->Home (no pause)->Relaunch). a) Recently Added gone (populated by itself during the initial scrape). b) Movies and TV Shows populated.

3) Did another cycle: (Return->Home (no pause)->Relaunch). a) Recently Added populated. b) Movies and TV Shows icons customized. c) Movies and TV Shows populated. e) Played movie just a bit.

I could not get it to fail afterwards no matter what I tried (upto this point, non-timed). I would say the above are just tiny nuisances that are easily fixed with a cycle or two. Seems to be just a glitch.

Will now initiate quick tests on Firestick 4K Max Wifi with TEST4. Will report back when done.

ghost commented 1 year ago

Take that back....

4) Did another cycle: (Return->Home (random pause)->Relaunch). a) Recently Added populated. b) Recently Played populated. c) Movies and TV Shows icons generic! d) Movies library empty! e) TV Shows library empty! f) Activated Re-scan on app startup.

5) Return->Home (no pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty.

6) Return->Home (random pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated.

7) Return->Home (random pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty. f) De-activated Re-scan on app startup.

8) Return->Home (no pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Movies and TV Shows icons customized. d) Movies library populated. e) TV Shows library populated.

9) Return->Home (random pause)->Relaunch. a) All correct.

10) Return->Home (no pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Movies and TV Shows icons generic. d) Movies library populated. e) TV Shows library populated.

11) Return->Home (random pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty.

12) Return->Home (no pause)->Relaunch. a) Recently Added gone. b) Recently Played gone. c) Movies and TV Shows icons generic. d) Movies library empty. e) TV Shows library empty.

13) Return->Home (long-ish random pause)->Relaunch. a) All correct.

14) Return->Home (no pause)->Relaunch. a) Recently Added populated. b) Recently Played populated. c) Movies and TV Shows icons generic. d) Movies library populated. e) TV Shows library populated.

This is failing...

ghost commented 1 year ago

@courville Given the above tests, TEST4 is a fail on Firecube 4K Gen2 Wired.

If you wish me capture logs, dbs, etc., and/or conduct tests (TEST4) on Firestick 4K Max, will be happy to do so Sunday (since Sabbath is within the hour for us).

I really thought and hoped this was a done deal... Sad to see this fail :(

I'm here to help.

courville commented 1 year ago

@Molasar49 thanks again for all the testing and yes the result is very unsettling indeed :-( This means that my interpretation is not correct.

Let's sum it up:

TEST1 which is the same as before (i.e. current v6.1.2 and it should fail) i.e. no custom executor for VideoLoader and ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(5200)); for VideosSelectionLoader and no throttling of loaders -> FAILURE
TEST2 which has custom executor ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(5200)); both for VideoLoader and VideosSelectionLoader and still no throttling of loaders -> SUCCESS
TEST3 no custom executor and no throttling in VideoLoader and VideosSelectionLoader -> SUCCESS
TEST4 which has identical custom executor ThreadPoolExecutor(1, 4, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(256)); both for VideoLoader and VideosSelectionLoader and no throttling -> FAILURE

This contradicts my hypothesis of having identical executors for VideoLoader and VideosSelectionLoader solving the issue (which is the case of TEST2 working and TEST4 not working). However not messing with executors works too (TEST3). I am also focusing on VideoLoader and VideosSelectionLoader while in the firetv tests, no use of VideosSelectionLoader is made. This would hint that only VideoLoader should be considered (to be confirmed).

Thus what I need to do is:

test of focussing on same executor for VideoLoader and VideosSelectionLoader but not customizing the VideosSelectionLoader since it should inherit from VideoLoader one, works
revert to TEST2 config for release if it fails

At least we have configurations working (unexplained): I will share one new build today following above points if this is ok with you.

courville commented 1 year ago

@Molasar49, OK new round of test builds (you can skip testing TEST6 if TEST5 works): all builds have no throttling, no custom executor for VideosSelectionLoader all inherited from VideoLoader:

TEST5 where VideoLoader uses custom ThreadPoolExecutor(1, 4, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(256))
TEST6 where VideoLoader uses custom ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(5200)) (should be same as working TEST2 thus working but with only one customization in VideoLoader)
TEST7 where VideoLoader does not use any custom executor (i.e. it thus uses mother ModernAsyncTask one which is ThreadPoolExecutor(5, 128, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(10)) on Android but no clue on fireOS)

I am sorry to impose on you all this testing but I am sure that you are not alone in seeing the issue.

ghost commented 1 year ago

@courville Not a problem. Will start testing tomorrow. Thanks again for all the effort!

ghost commented 1 year ago

@courville, Initiating TEST5 random quick tests on Firecube 4K Gen2 Wired. Will report (control and unusual observations) as I go...

ghost commented 1 year ago

TEST5

1) Uninstalled previous version. 2) Reboot (to provide for a clean test). 3) Wait 2 minutes for device to "settle" (finish loading any background processes). 4) Install. All permissions granted (as usual). 5) Preferences>About shows v6.1.3 (20230325.1810) 6) Initial scan in progress... a) Recently Added populated during initial scan. 7) Waited 2 minutes and counting... a) Movies and TV Shows icons generic. b) Movies library populated c) TV Shows library populated d) Upon return from both libraries, icons still generic. 8) 1 cycle (Return->Home (no pause)->Relaunch. a) Movies and TV Shows customized icons. b) Movies library populated c) TV Shows populated. 9) Played random movie. a) Recently Played populated.

Initiating random cycles...

ghost commented 1 year ago

10) Return->Home (no pause)->Relaunch. a) Movies and TV Shows icons generic b) Everything else correct. 11) Return->Home (2s pause)->Relaunch. a) Movies and TV Shows icons generic b) Recently Added populated c) Recently Played populated d) Movies library empty! e) TV Shows empty! 12) Return->Home (random pause)->Relaunch. a) Recently Added gone! b) Recently Played gone! c) Movies and TV Shows icons customized d) Movies library populated e) TV Shows populated

ghost commented 1 year ago

It's getting harder and harder to get this one to fail, but I just did again after some random cycles:

13) Return->Home (random pause)->Relaunch. a) Recently Added populated b) Recently Played populated c) Movies and TV Shows icons generic d) Movies library empty! e) TV Shows empty! 14) Return->Home (no pause)->Relaunch. a) Recently Added gone! b) Recently Played gone! c) Movies and TV Shows icons generic d) Movies library empty! e) TV Shows empty!

At this point (just made it fail -aka: empty libraries- 2 times in a row with random cycles), will declare this version a fail, and will continue with TEST6 in the spirit of getting all versions tested.

Can go back later and reinstall this version if you need logs, dbs etc.

ghost commented 1 year ago

TEST6

1) Uninstalled previous version. 2) Reboot (to provide for a clean test). 3) Wait 2 minutes for device to "settle" (finish loading any background processes). 4) Install. All permissions granted (as usual). 5) Preferences>About shows v6.1.3 (20230325.1822) 6) Initial scan in progress... a) Recently Added populated during initial scan. 7) Waited 2 minutes and counting... a) Movies and TV Shows icons generic. b) Movies library populated c) TV Shows library populated d) Upon return from both libraries, icons still generic. 8) 1 cycle (Return->Home (no pause)->Relaunch. a) Movies and TV Shows customized icons. b) Movies library populated c) TV Shows populated. 9) Played random movie. a) Recently Played populated.

Initiating random cycles...

ghost commented 1 year ago

10) Return->Home (no pause)->Relaunch. a) Movies and TV Shows icons generic b) Everything else correct. 11) Return->Home (random pause)->Relaunch. a) Recently Added gone! b) Recently Played populated c) Movies and TV Shows icons generic d) Movies library empty! e) TV Shows empty! 12) Return->Home (short random pause)->Relaunch. a) Recently Added gone! b) Recently Played gone! c) Movies and TV Shows icons customized d) Movies library populated e) TV Shows populated 13) Return->Home (no pause)->Relaunch. a) Recently Added populated b) Recently Played populated c) Movies and TV Shows icons generic d) Movies library gone! e) TV Shows gone! 14) Return->Home (no pause)->Relaunch. a) Recently Added populated b) Recently Played populated c) Movies and TV Shows icons generic d) Movies library populated e) TV Shows populated

ghost commented 1 year ago

Up to this point, I can sometimes get the generic icons to appear, but am having a hard time getting the libraries to appear empty...

To recap, could initially get this version to fail, but afterwards no matter what I tried, the best I could do was get the generic library icons to appear. Everything else seems correct. Big improvement over the last few versions, but from a normal user's point of view, I still think TEST3 is the best one and still reigning champion. TEST6 is a close 2nd place.

Will proceed now with TEST7.

Update: Just got TEST6 to fail again (empty libraries after about a 5 minute pause). Another random cycle and both Recents gone. TEST6 is now a distant 2nd place to TEST3.

ghost commented 1 year ago

TEST7

1) Uninstalled previous version. 2) Reboot (to provide for a clean test). 3) Wait 2 minutes for device to "settle" (finish loading any background processes). 4) Install. All permissions granted (as usual). 5) Preferences>About shows v6.1.3 (20230325.1833) 6) Initial scan in progress... a) Recently Added populated during initial scan. 7) Waited 3+ minutes and counting... a) Movies and TV Shows icons generic. b) Movies library populated c) TV Shows library populated d) Upon return from both libraries, icons still generic. 8) 1 cycle (Return->Home (no pause)->Relaunch. a) Movies and TV Shows still generic icons. b) Movies library populated c) TV Shows populated. 9) Played random movie. a) Recently Played populated. b) Still Movies and TV Shows generic icons 10) A few random cycles after... a) Movies and TV Shows customized icons

Initiating random cycles...

courville commented 1 year ago

Thanks for all the testing: thinking about it and carefully reading your reports, I am now getting convinced that something is not handled properly in the MainFragment livecycle when exiting and re-entering and perhaps not with the VideoLoader... You are insisting on the "Movies and TV Shows generic icons" a lot and it is indeed wrong. I will wait for your final results on TEST7 and will get back on analyzing MainFragment.

ghost commented 1 year ago

@courville With TEST7, can sometimes get generic icons displayed, but libraries are always populated. Could not get it to fail. TEST7 is VERY close to TEST3 (which I regard as the benchmark; just my opinion).

I can almost see a pattern getting generic icons to show... (quick non-pause cycles usually gets generic icons); other than that, seems to be VERY close being a winner. As a note, I use TEST3 as my day-to-day version for my personal viewing with my family, and have yet to make it fail (not trying to on a daily basis; just a normal use experience). To my memory, just got it to display generic icons 1 single time (could have been just a random device glitch).

Hope all this testing works. If you need logs, dbs or anything else (testing on Firestick, etc.), please let me know.

ghost commented 1 year ago

UPDATE: Absolutely could not get TEST7 to show empty libraries, but can get it to show generic icons with quick, non-pause cycles on (an almost consistent) basis.

Hope this helps!

courville commented 1 year ago

It does help. I need to process all this now. FYI TEST7 is almost TEST3. Just a quick question: do you confirm that on all the tests above you do not have automatic rescan at application launch?

ghost commented 1 year ago

It does help. I need to process all this now. FYI TEST7 is almost TEST3. Just a quick question: do you confirm that on all the tests above you do not have automatic rescan at application launch?

Yes, I did not have Re-scan on app start set to Yes. Do you want me to set this option to Yes and retest?

courville commented 1 year ago

Not now, let's focus on this first use case (which is the most common one).

ghost commented 1 year ago

@courville Got it. Anything else, let me know. Thanks!

nova-video-player / aos-AVP