novacbn / kahi-ui

Straight-forward Svelte UI for the Web
https://kahi-ui.nbn.dev
MIT License
187 stars 5 forks source link

Invalid prop "variation" for Menu.Buton component #119

Closed demetrius-mp closed 2 years ago

demetrius-mp commented 2 years ago

Describe the Bug

When using the component with the "variation" prop, vscode shows an Not assignable type error.

Reproduction

I was able to find the bug by simply copying and pasting the code for the Omni component from the official docs (here).

Here is an image of the error image

Here is the complete error message displayed by vscode when i hover the variation prop: (JSX attribute) variation: string Type '{ variation: string; active: true; }' is not assignable to type 'IntrinsicAttributes & { actions?: IForwardedActions; element?: HTMLLIElement; active?: boolean; disabled?: boolean; palette?: "auto" | ... 7 more ... | "negative"; ... 7 more ...; hidden?: PROPERTY_HIDDEN; }'. Property 'variation' does not exist on type 'IntrinsicAttributes & { actions?: IForwardedActions; element?: HTMLLIElement; active?: boolean; disabled?: boolean; palette?: "auto" | ... 7 more ... | "negative"; ... 7 more ...; hidden?: PROPERTY_HIDDEN; }'.js(2322)

System Info

System:
    OS: Linux 5.15 Pop!_OS 21.10
    CPU: (12) x64 Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz
    Memory: 9.43 GB / 15.54 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Firefox: 96.0

Additional Context

No response

novacbn commented 2 years ago

Thanks for the report! Was just a proofreading mistake on my part, variation doesn't exist on <Menu.Button>.

demetrius-mp commented 2 years ago

Fine! i guess you can close the issue if you wish.