novacoin-project / novacoin

Novacoin sources tree
MIT License
114 stars 517 forks source link

Can't send transactions after latest update #392

Closed laakie closed 2 years ago

laakie commented 2 years ago

From log:

RPCServer method=sendrawtransaction ERROR: Non-canonical signature: S value is unnecessarily high ERROR: CScriptCheck() : d164cc9248 VerifySignature failed ERROR: ConnectInputs() : d164cc9248 strict VerifySignature failed ERROR: CTxMemPool::accept() : ConnectInputs failed d164cc9248

got same result with sendtransaction

CryptoManiac commented 2 years ago

Hi. This issue has been confirmed by other reports. It will be resolved with next update. Thank you for your report.

laakie commented 2 years ago

Thanks a lot, any eta for the patch ?

CryptoManiac commented 2 years ago

Issue has been fixed already but there is no release yet. I think this will be done tomorrow.

laakie commented 2 years ago

Great, thank you very much. Can we try the "master" repo before release ?

CryptoManiac commented 2 years ago

I wouldn’t recommend it for now, because few tests are yet to be completed. I’ll close this issue once release will be published.

There is a workaround though. You can repeat sending attempts until signature will satisfy network requirements. Just remember to use RBF to stay safe from double spending attempts by malicious users. Using consequent values of nSequence field of your transactions will guarantee that no double spending is done by your users. Though I would really prefer to wait for real fix instead of relying on workarounds.

laakie commented 2 years ago

Alright, We'll better wait for the release just to be sure then.

laakie commented 2 years ago

all good after updating, thanks again for the great work done