search

novacrazy / dual_num

Dual Number library for Rust
https://docs.rs/dual_num/
17 stars 4 forks source link

Add default trait and inline all short functions #8

Closed benruijl closed 5 years ago

benruijl commented 5 years ago

Fixes #6 and #7.

ChristopherRabotin commented 5 years ago

I am on-board with these changes.

For the sake of regression testing, I would recommend simply adding a test for Default. I am not aware of any way that we can test the in-line flags.

On Mon, Nov 19, 2018, 07:10 Ben Ruijl notifications@github.com wrote:

Fixes #6 https://github.com/novacrazy/dual_num/issues/6 and #7 https://github.com/novacrazy/dual_num/issues/7.

You can view, comment on, or merge this pull request online at:

https://github.com/novacrazy/dual_num/pull/8 Commit Summary

  • Added default trait
  • Inline all short functions

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/novacrazy/dual_num/pull/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AEma6LOQ2uKDHgxo-pJ6mG0fl132ZzHRks5uwrvFgaJpZM4YpLn7 .

benruijl commented 5 years ago

I've added a test!

ChristopherRabotin commented 5 years ago

That was quick, thanks! I approve of these changes.

I'll let @novacrazy give his approval as well.

On Mon, Nov 19, 2018, 07:23 Ben Ruijl notifications@github.com wrote:

I've added a test!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/novacrazy/dual_num/pull/8#issuecomment-439909229, or mute the thread https://github.com/notifications/unsubscribe-auth/AEma6O8rV6BgUG9qek6XGV_Y9Bkr9O7Aks5uwr7fgaJpZM4YpLn7 .

novacrazy commented 5 years ago

Yeah, this is fine. I'll go ahead and merge this, then publish a new minor release. Thanks, @benruijl!