search

novafacile / novagallery

novaGallery - a beautiful and and ease to use php image gallery for your photos - flat file - no database required - modern responsive design
https://novagallery.org
GNU Affero General Public License v3.0
76 stars 13 forks source link

Not closing PHP ?> is considered better practice #2

Closed ibes closed 1 year ago

ibes commented 2 years ago

Hi there,

cool tool. Seems to be just as much as needed to have a gallery. I like that style and love that I am able to get every line of the code as it is few enough lines to understand everything.

A small hint: Not closing the PHP tags is considered better practice as it avoids the risk of having whitespace after them.

david-novafacile commented 2 years ago

Thank you very much! That is a good point and will be considered in the next version.

david-novafacile commented 2 years ago

Will be fixed in v2