novalagung / muslimboard

🕌 Muslim Board Browser Extension
https://muslimboard.novalagung.com
MIT License
144 stars 28 forks source link

feat: Add settings modal and Hijri date option. #35

Closed MohammedAyman2018 closed 1 year ago

MohammedAyman2018 commented 1 year ago

In this commit I suggest few improvements to the UI.

I'm open to discuss the changes and any further ideas. Hope you check your mail as well :)

novalagung commented 1 year ago

hi @MohammedAyman2018

I prefer to have the old footer. although it consumes much more space on the bottom section, it is easier for the user to change language & click location buttons. and I don't think having more space on the bottom side is worth the UX cost.

Also the new UI of the popup (when Settings button is clicked) is not consistent with the rest popups/modals.

image

I like the idea to add Hijri date. I think we can just display it on the screen along with the Gregorian date. Kindly please create a new PR for this particular updates.

On separate note, yes I saw your email and have replied it. Would really appreciate if you can help us with the Arabic localization :-) I can provide additional details if you are ok

MohammedAyman2018 commented 1 year ago

Thanks for your time. I didn't say the current UX isn't good I was just suggesting 😄. I can help with Arabic localization will create a new PR for it and contact you for more details.

novalagung commented 1 year ago

hi @MohammedAyman2018, please check on https://github.com/novalagung/muslimboard/issues/36, I put the details about adding new localization there. Really appreciate your help, thank you!