search

novalagung / muslimboard

🕌 Muslim Board Browser Extension
https://muslimboard.novalagung.com
MIT License
137 stars 28 forks source link

Arabic localization #42

Closed MohammedAyman2018 closed 1 year ago

novalagung commented 1 year ago

@MohammedAyman2018 thank you, I'll review this PR shortly and create patch release

MohammedAyman2018 commented 1 year ago

Assalamu alaikum wa rahmatullahi wa barakatuh, I'm happy to see the new version Ø©ay Allah reward you immensely. There's just a small note the direction is still ltr. It has to be rtl. I've made this change already in the commits.

Thanks in advance.

novalagung commented 1 year ago

hi @MohammedAyman2018, I reviewed the PR and tested it in my local environment.

I want to hold these changes for now. I understand that RTL should be the default text direction for the Arabic language, and for that, I agree. The only thing concerned about is the component/section direction. flipping the layout horizontally is causing some issues with the styling.

Let us get back to this PR later. and at that time I might reopen this PR.

Really appreciate your help on the Arabic localization! thank you