search

novalagung / muslimboard

🕌 Muslim Board Browser Extension
https://muslimboard.novalagung.com
MIT License
144 stars 28 forks source link

feat: add remaining time until next prayer time #59

Closed kotopanjang closed 9 months ago

kotopanjang commented 9 months ago

new fearture preview https://drive.google.com/file/d/1QLauZp9eLuoybs9Li4zgon8zdyvI-Ao7/view?usp=sharing

novalagung commented 9 months ago

thanks @kotopanjang I'll review it and get it merged by this weekend

novalagung commented 9 months ago

@kotopanjang thanks for the PR. I made some changes on the UI side (see the 2nd image). the original proposed UI looks ok, but I feel it doesn't communicate the remaining time clearly enough. therefore I updated the messages and added the translation alongside with it.

Also, the proposed update has some UI problem when the timezone contains more than 3 characters.

Now I'm evaluating the changes by doing some local testing on my env. if it looks good I shall merge the changes today. Thanks for the help!

kotopanjang commented 9 months ago

@kotopanjang thanks for the PR. I made some changes on the UI side (see the 2nd image). the original proposed UI looks ok, but I feel it doesn't communicate the remaining time clearly enough. therefore I updated the messages and added the translation alongside with it.

Also, the proposed update has some UI problem when the timezone contains more than 3 characters.

Now I'm evaluating the changes by doing some local testing on my env. if it looks good I shall merge the changes today. Thanks for the help!

  • Image 1 image
  • Image 2 image

NP. I didn't know if there are some timezones contains more than 3 characters 😅. And the new UI looks good tho. Thank you for considering the changes. it helps alot 😁