search

novasamatech / nova-spektr

Nova Spektr — All-in-one Polkadot desktop wallet supporting multisigs, staking, light clients, and more
https://novaspektr.io
Apache License 2.0
37 stars 14 forks source link

Basket. Confirm page. Wrong container boundaries #1915

Open stepanLav opened 5 days ago

stepanLav commented 5 days ago

Description

When user click on info button inside confirm page - appears scroll inside operation details view, that should appear on top of view and should not resize it.

Example https://github.com/novasamatech/nova-spektr/assets/40560660/a9493d81-40c6-4425-b493-150b095168a0

Steps to Reproduce

  1. Add a few transfer operations into the Basket
  2. Sign all this operations
  3. Click on Info button on confirm page

Expected Behavior

Info window opens on top of confirm page

Actual Behavior

Resize confirm page, add scroll

Environment

https://github.com/novasamatech/nova-spektr/commit/0945304b07f45f1847ae67b4774db302874a3971

Asmadek commented 3 days ago

Headless UI 2 support portals for popover, it can help to resolve this issue, but it requires more effort to adopt all places where we use old headless ui, or use both libraries together