search

novasamatech / nova-wallet-dapp-js

Minimal js bridge to connect to web dapps from mobile app
4 stars 4 forks source link

Injected extension name #14

Open youPickItUp opened 6 months ago

youPickItUp commented 6 months ago

I think it would be more appropriate if you could use different name than original polkadot-js extension: https://github.com/novasamatech/nova-wallet-dapp-js/blob/eb269ad99be14736c3ff3bad85ab035d6b073993/src/index.ts#L9 In case of Nightly Connect integration we are currently using, it shows your extension as polkadot-js with their icon and name.

Disclaimer -- Even though I'm not aware of any issues such change could bring it could be possible that some site allows only polkadot-js integration. If that's the case... well :hankey:

youPickItUp commented 6 months ago

@leohar, sorry to bother you. I just didn't want the issue to be left unnoticed :see_no_evil: