search

novasamatech / parity-signer

Air-gapped crypto wallet.
https://www.parity.io/signer/
GNU General Public License v3.0
549 stars 163 forks source link

More identicon flavors #877

Open Slesarew opened 2 years ago

Slesarew commented 2 years ago

We need new visually distinctive identicons!

Slesarew commented 2 years ago

This could be moved to later milestone, but we need to decide: either we use current identicons and then replace them with other flavor, or use none until we have a replacement.

goldsteinsveta commented 2 years ago

Let's use the current ones. I can design something, but given this element is used in 99% of applications interacting w substrate-based chains, I think it should be thought through properly. I'd ask for an input from graphic designers too.

Slesarew commented 2 years ago

Query math geeks for algorithm too.

Tbaut commented 2 years ago

My 2 cents here, Identicons are only useful if they are a standard. If every app creates their own, it's not helping anyone any more. I'd look at what Identicons are used in dapps, extensions etc, and go with this.

goldsteinsveta commented 2 years ago

Agree, parity-signer is not a target here. It's better to setup a separate repo

Slesarew commented 2 years ago

I want every identicon flavor in it's own repo! Compartmentalizing them is trivial and they should be re-used as much as possible.

Re-using something existing is a good approach indeed, but it's all about having pretty things, metadata check will be quite unique thing and if it does not look familiar - that's all better. Still, identicon is actually part of crypto flow, so re-implementing it just for fun is not exactly safe approach; we are discussing it only because it's such a soft human-involving matter.

kirushik commented 2 years ago

Well, at the same time some Signer-specific identities (like metadata/network specs) don't have any representation in any other interface so far, so we can go wild with designing (and specifying+modularizing!) new identicon systems for those usecases.

It might also turn out to be beneficial for UX/UI: having different kinds of things having different, visually distinct identicon systems might help avoiding confusion.

That said, accoint IDs are staying on the current identicon system, changing that is out of the question.

goldsteinsveta commented 2 years ago

It is Signer-specific, but it does not appear only on Signer's GUI. Metadata/network specs are also relevant for any metadata update portal and its developers. It could be anyone in the ecosystem. I also hear requests for scripts to generate own metadata. Those who will generate it for themselves, probably would like some GUI too