search

novastone-media / MQTT-Client-Framework

iOS, macOS, tvOS native ObjectiveC MQTT Client Framework
Other
1.84k stars 466 forks source link

MQTTClient imports MQTTSessionManager directly #429

Closed ogres closed 6 years ago

ogres commented 6 years ago

Hello,

After updating to 0.11.0 I got a compilation error because of missing MQTTSessionManager.h file.

I am using 'MQTTClient/Min' , min does not include MQTTSessionManager, but MQTTClient.h tries to import it anyway.

Its easily reproducible on a fresh project,

Then open Workspace, import MQTTClient and press compile.

Solution would be to add compilation directives, to only import MQTTSessionManager when its available.

jcavar commented 6 years ago

Thanks, you are right yes. This should have been caught on CocoaPods publish but I think I disabled that check and it went through.

Sorry about this, will try to fix it as soon as possible.

jcavar commented 6 years ago

Fixed by https://github.com/novastone-media/MQTT-Client-Framework/commit/1d094841a5bbc49a8a8ef69e5f8bc9a4e65ce6f6 and https://github.com/novastone-media/MQTT-Client-Framework/commit/6eff8d5e8569305435474e147d4eac1c1b562677

Will release to CocoaPods soon.

jcavar commented 6 years ago

Released 0.12.0

ogres commented 6 years ago

Thank you!