search

novastone-media / MQTT-Client-Framework

iOS, macOS, tvOS native ObjectiveC MQTT Client Framework
Other
1.84k stars 466 forks source link

Some imports are missing for MQTTClient's umbrella header #440

Closed olbartek closed 6 years ago

olbartek commented 6 years ago

Xcode says that umbrella header for module MQTTClient does not include some headers. I am attaching screenshot with the issue.

screen shot 2018-03-23 at 21 35 09

The issue occurred to me in a Swift project and it does not occur every time. I've noticed that when you clean derived data it is more likely to happen.

jcavar commented 6 years ago

Thank you for reporting this. Some of those classes are private and are not imagined to be exposed to outside so I am not sure if we should add them? I would like to fix warnings you are getting though. Do you know any other way to silence warning without including those files?

mciuba commented 6 years ago

Maybe the problem is caused by all these headers being set as "public" in "Target Membership"? As described in this answer: https://stackoverflow.com/a/38740111/2128900 Setting the headers which shouldn't be exposed to the outside to "private" in "Target Membership" could fix the issue

jcavar commented 6 years ago

That makes sense. If someone wants to give it a try it would be nice, otherwise I will do it when I find some time.

kprofic commented 6 years ago

I have just sent a PR this does exactly this: some headers are moved to "project" instead of "public"

jcavar commented 6 years ago

Ok, 0.13.1 is out now. Please give it a try.

kprofic commented 6 years ago

Seems to work fine now, thanks!