search

novastone-media / MQTT-Client-Framework

iOS, macOS, tvOS native ObjectiveC MQTT Client Framework
Other
1.84k stars 463 forks source link

Hiding SocketRocket from public headers #542

Closed MWingbermuhle closed 4 years ago

MWingbermuhle commented 4 years ago

We are making an attempt to integrate the MQTT-Client-Framework into a Kotlin-Native library. Unfortunately that breaks because of the SocketRocket reference on the public headers of your library.

gvdhoven commented 4 years ago

@JackLeo the CI is failing because of 2 phones not available; the builds succeed on other platforms which are available. We are planning to use your library in a release from us which is imminent. Can you please take a look at it and merge it if you have time?

jcavar commented 4 years ago

Do you actually need MQTTWebSocketTransport? If no, can you exclude those files? If you need them, then they won’t work without SocketRocket.

MWingbermuhle commented 4 years ago

Yes, we do really need the WebSocket transport to be able to talk to Amazon IoT. We are not trying to remove the SocketRocket library in general, just hiding it from the public API (header) where it does not seem to be needed anyway.

jcavar commented 4 years ago

You are right! Thank you.

MWingbermuhle commented 4 years ago

@jcavar Thank you too. Is there any chance that you can make a release out of this in the near future?

jcavar commented 4 years ago

Done, 0.15.3. Let us know if you have any issues.