search

novatel / novatel_edie

The EDIE (Encode Decode Interface Engine) software development kit allows interfacing and decoding data output from NovAtel's OEM7 receivers.
MIT License
16 stars 6 forks source link

Duplicated Header Files #1

Closed roamingryan closed 9 months ago

roamingryan commented 2 years ago

Best I can tell, this repo contains two fully redundant copies of the project header files. Is there a reason for this? It certainly hinders maintainability of the project. This could be cleaned up in CMake with use of include_directory() (and related commands).

novatel_edie$ fdupes -r -A ./src ./bin
./src/hw_interface/stream_interface/api/multioutputfilestream.hpp
./bin/StreamInterface/api/multioutputfilestream.hpp

./src/hw_interface/stream_interface/api/inputmemorystream.hpp
./bin/StreamInterface/api/inputmemorystream.hpp

./src/hw_interface/stream_interface/api/filestream.hpp
./bin/StreamInterface/api/filestream.hpp

./src/hw_interface/stream_interface/api/inputstreaminterface.hpp
./bin/StreamInterface/api/inputstreaminterface.hpp

./src/hw_interface/stream_interface/api/outputstreaminterface.hpp
./bin/StreamInterface/api/outputstreaminterface.hpp

./src/hw_interface/stream_interface/api/outputfilestream.hpp
./bin/StreamInterface/api/outputfilestream.hpp

./src/hw_interface/stream_interface/api/outputportstream.hpp
./bin/StreamInterface/api/outputportstream.hpp

./src/hw_interface/stream_interface/api/outputmemorystream.hpp
./bin/StreamInterface/api/outputmemorystream.hpp

./src/hw_interface/stream_interface/api/inputfilestream.hpp
./bin/StreamInterface/api/inputfilestream.hpp

./src/hw_interface/stream_interface/api/memorystream.hpp
./bin/StreamInterface/api/memorystream.hpp

./src/hw_interface/stream_interface/api/inputportstream.hpp
./bin/StreamInterface/api/inputportstream.hpp

./src/hw_interface/dynamic_library/api/hwinterface_export.h
./bin/hwinterface_dynamic_library/api/hwinterface_export.h

./src/hw_interface/dynamic_library/api/version.hpp
./bin/hwinterface_dynamic_library/api/version.hpp

./src/hw_interface/dynamic_library/api/stream_interface.hpp
./bin/hwinterface_dynamic_library/api/stream_interface.hpp

./src/decoders/jsoninterface/api/enums.hpp
./bin/JsonInterface/api/enums.hpp

./src/decoders/jsoninterface/api/types.hpp
./bin/JsonInterface/api/types.hpp

./src/decoders/jsoninterface/api/jsonfilereader.h
./bin/JsonInterface/api/jsonfilereader.h

./src/decoders/jsoninterface/api/logutils.hpp
./bin/JsonInterface/api/logutils.hpp

./src/decoders/jsoninterface/api/messageparams.hpp
./bin/JsonInterface/api/messageparams.hpp

./src/decoders/jsoninterface/api/loaddatafromjson.hpp
./bin/JsonInterface/api/loaddatafromjson.hpp

./src/decoders/jsoninterface/api/message.hpp
./bin/JsonInterface/api/message.hpp

./src/decoders/dynamic_library/doc/conf.py
./src/hw_interface/dynamic_library/doc/conf.py

./src/decoders/dynamic_library/doc/index.rst
./src/hw_interface/dynamic_library/doc/index.rst

./src/decoders/dynamic_library/api/novatel.hpp
./bin/decoders_dynamic_library/api/novatel.hpp

./src/decoders/dynamic_library/api/version.hpp
./bin/decoders_dynamic_library/api/version.hpp

./src/decoders/dynamic_library/api/decoders_export.h
./bin/decoders_dynamic_library/api/decoders_export.h

./src/decoders/dynamic_library/api/framer.hpp
./bin/decoders_dynamic_library/api/framer.hpp

./src/decoders/common/api/stringtotypes.hpp
./bin/Common/api/stringtotypes.hpp

./src/decoders/common/api/unknowndatahandler.hpp
./bin/Common/api/unknowndatahandler.hpp

./src/decoders/common/api/messagecounter.hpp
./bin/Common/api/messagecounter.hpp

./src/decoders/common/api/nexcept.h
./bin/Common/api/nexcept.h

./src/decoders/common/api/crc24.hpp
./bin/Common/api/crc24.hpp

./src/decoders/common/api/circularbuffer.hpp
./bin/Common/api/circularbuffer.hpp

./src/decoders/common/api/common.hpp
./bin/Common/api/common.hpp

./src/decoders/common/api/env.hpp
./bin/Common/api/env.hpp

./src/decoders/common/api/basemessagedata.hpp
./bin/Common/api/basemessagedata.hpp

./src/decoders/common/api/crc32.hpp
./bin/Common/api/crc32.hpp

./src/decoders/novatel/test/main.cpp
./src/decoders/common/test/main.cpp
./src/decoders/jsoninterface/test/main.cpp
./src/hw_interface/stream_interface/test/main.cpp

./src/decoders/novatel/test/resources/decoder_bestpos.asc
./src/hw_interface/stream_interface/test/resources/decoder_bestpos.asc

./src/decoders/novatel/test/resources/advancedecoder_bestpos.bin.asc
./src/hw_interface/stream_interface/test/resources/outputfilestream_file1.asc
./src/hw_interface/stream_interface/test/resources/outputfilestream_file2.asc

./src/decoders/novatel/doc/conf.py
./src/decoders/common/doc/conf.py
./src/decoders/jsoninterface/doc/conf.py
./src/hw_interface/stream_interface/doc/conf.py

./src/decoders/novatel/doc/index.rst
./src/decoders/common/doc/index.rst
./src/decoders/jsoninterface/doc/index.rst
./src/hw_interface/stream_interface/doc/index.rst

./src/decoders/novatel/api/encodercommon.hpp
./bin/Novatel/api/encodercommon.hpp

./src/decoders/novatel/api/asciitobinarycomposer.hpp
./bin/Novatel/api/asciitobinarycomposer.hpp

./src/decoders/novatel/api/composer.hpp
./bin/Novatel/api/composer.hpp

./src/decoders/novatel/api/novatelparser.hpp
./bin/Novatel/api/novatelparser.hpp

./src/decoders/novatel/api/filters/sattimefilter.hpp
./bin/Novatel/api/filters/sattimefilter.hpp

./src/decoders/novatel/api/filters/filtercontainer.hpp
./bin/Novatel/api/filters/filtercontainer.hpp

./src/decoders/novatel/api/filters/timefilter.hpp
./bin/Novatel/api/filters/timefilter.hpp

./src/decoders/novatel/api/filters/decimationfilter.hpp
./bin/Novatel/api/filters/decimationfilter.hpp

./src/decoders/novatel/api/filters/sourcefilter.hpp
./bin/Novatel/api/filters/sourcefilter.hpp

./src/decoders/novatel/api/filters/messagefilter.hpp
./bin/Novatel/api/filters/messagefilter.hpp

./src/decoders/novatel/api/filters/messagedatafilter.hpp
./bin/Novatel/api/filters/messagedatafilter.hpp

./src/decoders/novatel/api/decoder.hpp
./bin/Novatel/api/decoder.hpp

./src/decoders/novatel/api/encoder.hpp
./bin/Novatel/api/encoder.hpp

./src/decoders/novatel/api/messagesinfo.hpp
./bin/Novatel/api/messagesinfo.hpp

./src/decoders/novatel/api/framer.hpp
./bin/Novatel/api/framer.hpp

./src/decoders/novatel/api/binarytoasciicomposer.hpp
./bin/Novatel/api/binarytoasciicomposer.hpp

./src/decoders/novatel/api/separator.hpp
./bin/Novatel/api/separator.hpp
novatel-applications-engineering commented 9 months ago

Thank you for your contribution and effort in this issue. I wanted to update you that this issue has already been addressed in the latest version of EDIE.