search

novatel / novatel_oem7_driver

ROS Driver for NovAtel OEM7 GNSS/SPAN Receivers
https://wiki.ros.org/novatel_oem7_driver
MIT License
105 stars 56 forks source link

Namespaces not supported #15

Closed Timple closed 2 years ago

Timple commented 3 years ago

Describe the bug Using the launchfiles provided, it is not possible to use namespaces.

To Reproduce

roslaunch novatel_oem7_driver oem7_net.launch oem7_ip_addr:=1.1.1.1 __ns:=myrobot

Current behavior


SUMMARY
========

PARAMETERS
 * /novatel/oem7/oem7_msgs/BDSEPHEMERIS: 1696
 * /novatel/oem7/oem7_msgs/BESTPOS: 42
 * /novatel/oem7/oem7_msgs/BESTUTM: 726
 * /novatel/oem7/oem7_msgs/BESTVEL: 99
...
process[novatel/oem7/driver-1]: started with pid [333625]
...

Expected behavior


SUMMARY
========

PARAMETERS
 * /myrobot/novatel/oem7/oem7_msgs/BDSEPHEMERIS: 1696
 * /myrobot/novatel/oem7/oem7_msgs/BESTPOS: 42
 * /myrobot/novatel/oem7/oem7_msgs/BESTUTM: 726
 * /myrobot/novatel/oem7/oem7_msgs/BESTVEL: 99
...
process[/myrobot/novatel/oem7/driver-1]: started with pid [333625]
...

(Note the extra /myrobot at the beginning of the parameters and node names.

Environment (please complete the following information):

Additional context Solution should be easy by removing all prepending slashes. And maybe novatel_oem7 is less namespace-depth than novatel/oem7?

novatel-applications-engineering commented 3 years ago

Hi @Timple. Please create a support case with NovAtel Customer Support, we'll continue support from there rather than keeping it public in GitHub. To create a support case with NovAtel Customer Support, please email: support.novatel@hexagon.com with this issue (https://github.com/novatel/novatel_oem7_driver/issues/15) mentioned in the body of the email, and we will merge the existing information you already provided. Thank you!

novatel-applications-engineering commented 3 years ago

We confirmed the issue and have added this to our backlog.

As a quick-fix solution: As users have all the sources, if this becomes an urgent issue, you can make this namespace change yourself as quick solution.

Timple commented 2 years ago

So this issue cost us (and four Novatel engineers) half a day yesterday.

Would you mind keeping it open until it is actually solved?

(We didn't solve it yet because it isn't a daily issue for us, but this is probably why it's good to solve it anyway :slightly_smiling_face: )

novatel-applications-engineering commented 2 years ago

Apologies for the opening and closing of this issue. We have added it to our backlog of issues to fix and will implement in future releases.

Timple commented 2 years ago

For transparency reasons, wouldn't it be easier to keep issues open until resolved?