novatel / novatel_oem7_driver

ROS Driver for NovAtel OEM7 GNSS/SPAN Receivers
https://wiki.ros.org/novatel_oem7_driver
MIT License
105 stars 57 forks source link

Requesting support for ROS2 galactic #50

Open ajay1606 opened 2 years ago

ajay1606 commented 2 years ago

Novatel OEM7 driver build fails in recent ROS2 distribution (Galactic).

Has any plans to support newer distributions?

Regards Ajay

novatel-applications-engineering commented 2 years ago

Hi @ajay1606! Thank you for your question. We currently have plans to support Galactic, but have not had a huge demand thus far so it has not been implemented yet. We have been working on some improvements and bug fixes with higher priority.

Please upvote this thread if you are in need of a ROS2 version that supports Galactic.

ajay1606 commented 2 years ago

Thanks for your quick response, after a few workarounds, have been able to run novate_oem7_driver with ROS2 Galactic distribution without any issues. Confirmed data output without any issues.

I will report any issues are observed.

Regards, Ajay

Minipada commented 2 years ago

Hey, what fixes did you do? Do you have a fork we could use? Thanks

ajay1606 commented 2 years ago

Hello @Minipada

There are very few modifications performed to work in galactic distribution. Please note the following modification; File: /novatel_oem7_driver/src/oem7_message_node.cpp

image

Currently, with the above modification, there are no issues observed in getting data. Everything seems to be working fine.

Regards, Ajay

novatel-applications-engineering commented 2 years ago

Hello @Minipada, thank you for contacting us. Please see our commit history to ROS1 branch for our most recent changes and fixes applied: https://github.com/novatel/novatel_oem7_driver/commits/ros1

jeremyroy commented 2 years ago

Galactic is EOL soon, so efforts should probably focus on adding support for Humble - the next LTS release of ROS2.

novatel-applications-engineering commented 2 years ago

Hello @jeremyroy, thank you for your input. We will put in our feature to work on backlog.