novatel / novatel_oem7_driver

ROS Driver for NovAtel OEM7 GNSS/SPAN Receivers
https://wiki.ros.org/novatel_oem7_driver
MIT License
108 stars 57 forks source link

cmake warnings when compiling #88

Open Timple opened 6 months ago

Timple commented 6 months ago

NOTE Bug reports are not to contain personalized information. Use these forms to submit generalized reports about the open source novatel_oem7_driver. All other inquires should be directed to private communications channels with NovAtel Customer Support.

You may reach NovAtel Customer Support by contacting support.novatel@hexagon.com. Or, you may follow the general Support process explained here: https://docs.novatel.com/OEM7/Content/Front_Matter/Customer_Support.htm


Describe the bug Compiler warnings:

#31 1184.7 --- stderr: novatel_oem7_driver
#31 1184.7 Cloning into 'novatel_oem7_decoder'...
#31 1184.7 HEAD is now at d02ccc2 Updating minimum cmake version to satisfy warnings on ROS2 build farm
#31 1184.7 CMAKE Host :  Linux
#31 1184.7 CMAKE_SYSTEM_PROCESSOR:x86_64
#31 1184.7 CMAKE_LIB_SHARED:
#31 1184.7 ARCH is not Set, default to x64
#31 1184.7 ARCH is x64 & Building for 64 bit
#31 1184.7 CMAKE_C_FLAGS_DEBUG:    -g
#31 1184.7 CMAKE_CXX_FLAGS_DEBUG:  -g -std=gnu++11 -fPIC -D_LINUX_
#31 1184.7 CMAKE_C_FLAGS_RELEASE:  -s -O3 -DNDEBUG
#31 1184.7 CMAKE_CXX_FLAGS_RELEASE:-g -Wno-write-strings -Wno-format -Wno-format-security -Wno-overflow -std=gnu++11 -fPIC -D_LINUX_ -DNDEBUG -s
#31 1184.7 COMPILE_DEFINITIONS = 
#31 1184.7 COMPILE_DEFINITIONS = DATADIR="/home/noblean/ros/iron/system/build/novatel_oem7_driver/novatel_oem7_decoder/src/novatel_oem7_decoder/src/decoders/jsoninterface/test/resources/"
#31 1184.7 COMPILE_DEFINITIONS = DATADIR="/home/noblean/ros/iron/system/build/novatel_oem7_driver/novatel_oem7_decoder/src/novatel_oem7_decoder/src/decoders/novatel/test/resources/"
#31 1184.7 COMPILE_DEFINITIONS = DATADIR="/home/noblean/ros/iron/system/build/novatel_oem7_driver/novatel_oem7_decoder/src/novatel_oem7_decoder/src/hw_interface/stream_interface/test/resources/"
#31 1184.7 ---
#31 1184.7 Finished <<< novatel_oem7_driver [2min 58s]

To Reproduce Steps to reproduce the behavior: Build this package with colcon

Expected behavior No compiler warnings

Screenshots

Environment (please complete the following information):

Additional context I traced the problem to here: https://github.com/novatel/novatel_edie/blob/1.0.0/src/decoders/common/test/CMakeLists.txt

As novatel_edie is cloned from within this package. However the message is present in a test. Can the compilation of these tests be disabled completely by default? That would get rid of the warning message but also save compilation time for end-users.

novatel-applications-engineering commented 1 month ago

Hi Timple. Sorry for the delayed response. We are working on this and have some changes that we are reviewing internally.

novatel-applications-engineering commented 1 month ago

Hi Timple.

Thanks for bringing this up. We have changed the verbosity of the messages output from the tests to DEBUG. We're leaving the tests enabled by default as EDIE is part of the critical functionality for this driver so we need to be able to identify if there's issues with it.

In addition to EDIE, a couple of those error messages were generated from the CMakeLists.txt in src/novatel_oem7_driver. I have changed that on the humble branch to no longer output those messages. Those ones from your terminal are:

#31 1184.7 Cloning into 'novatel_oem7_decoder'...
#31 1184.7 HEAD is now at d02ccc2 Updating minimum cmake version to satisfy warnings on ROS2 build farm

Please let me know if this works for you and if you're still seeing any issues with regards to stderr output during standard operation of the driver.