search

novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
185 stars 42 forks source link

Re-organise Maths headers. #361

Closed RubyNova closed 2 years ago

RubyNova commented 3 years ago

The Maths headers (under include/NovelRT/Maths) are currently all self-contained. As per the new design philosophy, individual types should no longer be able to be included directly, but rather they should only be accessed via NovelRT.h or via their respective "namespace header", so Maths.h in this case. This also means moving all forward declarations and includes to this namespace header along with adding their respective preprocessor include guards and errors. You can see a good example of this implementation at include/NovelRT/Ecs/Ecs.h and the individual type headers.

anindyasen commented 3 years ago

Hello, I am participating in hacktoberfest, Can I work on this issue as a part of it? thank you

RubyNova commented 3 years ago

Hi there @anindyasen - sure, sorry for not seeing this earlier. I'll assign it to you. :)

RubyNova commented 2 years ago

Hi there @anindyasen - have you abandoned this?

RubyNova commented 2 years ago

Assuming ticket has been abandoned. Reopening.