novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
185 stars 42 forks source link

Adjust the way include paths are handled so it uses the project directory and not the CMake source directory. #448

Closed RubyNova closed 2 years ago

RubyNova commented 2 years ago

This should be a very low cost fix with good robustness benefit.

The goal here is to simply replace CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR and still have CMake work correctly.

This change should allow people to use the NovelRT Engine via FetchContent functionality.

bjauny commented 2 years ago

I'll check this!

RubyNova commented 2 years ago

Awesome, let us know if you need anything

bjauny commented 2 years ago

Running the steps of the README on a Linux Mint install I cannot build the project. I attach the error logs. Did I miss something? err.log

RubyNova commented 2 years ago

You have - but no worries I got you. :)

Our readme states we do not work with GCC at this time and it's due to the exact error about type punning you are getting.

If you can, please use clang or MSVC instead.

bjauny commented 2 years ago

Oh, I missed this! I got it, I'll try again, thanks for the quick feedback.