search

novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
183 stars 43 forks source link

Move Google Test to FetchContent #453

Closed capnkenny closed 2 years ago

capnkenny commented 2 years ago

Moves Google Test to Fetch Content call. Also cleans up a few loose ends in main.

EDIT: This PR also now includes updating CI to only invoke Conan to pull down dependencies that have not been migrated yet. All building should be done via CMake at this time.

capnkenny commented 2 years ago

So depending on the CMakeLists, if CMake policy CMP0077 isn't set CMake will ignore the set and force it back to default, which is ON in the case of jsonscons. I mainly did the change as it was similar to the one highlighted by Google Test (which came straight from their Quick Start Guide) to make sure that it's forced in the cache to be the value that we set it to.

It was also easier to keep it consistent lol.