Make internal methods public in the Resourceloader

novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.

MIT License

183 stars 43 forks source link

Make internal methods public in the Resourceloader #475

Closed RyadaProductions closed 2 years ago

RyadaProductions commented 2 years ago

This PR does a few things:

Make internal methods public and rename them to not have a suffix anymore
Remove the old public methods that would implicitly use a preset folder
The implementation of the abstract methods now prefixes the default folder if somebody uses a relative path

This makes the UX cleaner by only having 1 method instead of an overload and with added documentation is clear and easy to use.

Would solve Issue #444

RyadaProductions commented 2 years ago

Regarding the exceptions I would assume that anyone who does anything with filepaths will take FileNotFoundExceptions into account. Failing silently or handling it ourself is something I don't think we would want to do, because then the user won't know why a file isn't loading properly.