novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

Vendor OpenAL, libsndfile #477

Closed capnkenny closed 2 years ago

capnkenny commented 2 years ago

Self-titled. Can disregard branch name, originally was going to use libnyquist but floating point sound files weren't playing nice with OpenAL at all.

Seeing as I ran into a few heap corruption errors (that were fixed before I opened the PR), I wouldn't mind volunteers to try this branch out with AudioEcsSample :D

FiniteReality commented 2 years ago

I'm not a huge fan of us implementing the code needed to read/write these files ourselves. It opens us up to a bunch of security concerns that we need to handle correctly, and we can't use an upstream source to assist with that.

capnkenny commented 2 years ago

@FiniteReality Based on our discussion, the most recent commits revert back to libsndfile for file handling