search

novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
183 stars 43 forks source link

NovelRT C API deleter methods are inconsistently named. #513

Closed RubyNova closed 1 year ago

RubyNova commented 1 year ago

Note: for support questions, please use the #engine-user-help channel in our Discord or create a discussion. This repository's issues are reserved for feature requests and bug reports.

Describe the issue: There is a naming inconsistency in the C API where some of the deleter methods are tagged as Delete and some as Destroy.

Please provide the steps to reproduce if possible:

  1. Clone the repo
  2. Inspect the interop header files
  3. Observe the issue

Expected behaviour: I believe the intended naming convention is Destroy.

Please tell us about your environment:
N/A

Additional context: This doesn't functionally break anything, its just gross to read.

Sakshi-75 commented 1 year ago

Hi @RubyNova , Can I work on this?

RubyNova commented 1 year ago

@Sakshi-75 Sure. Assigned.