novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
183 stars 43 forks source link

Fixes #513: Renamed deleter methods to destroy #514

Closed Sakshi-75 closed 1 year ago

Sakshi-75 commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This PR renames deleter methods in the interop by replacing delete word with destroy to maintain consistent method naming throughout.

Is there an open issue that this resolves? If so, please link it here. Resolves #513

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No

Other information:

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

Sakshi-75 commented 1 year ago

Hi @RubyNova , I addressed all the PR comments. Can you check if anything got missed? Thanks!

RubyNova commented 1 year ago

All that's really missing is updating the branch with main since something else got merged since this PR was opened. I've enabled auto merge but it won't merge until:

The contents of the PR itself is fine. :)