search

novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
183 stars 43 forks source link

CI: GitHub Actions need updating where applicable for `actions` steps. #516

Open capnkenny opened 1 year ago

capnkenny commented 1 year ago

Describe the issue: Currently, we are getting the following warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

We will want to update any actions/* actions to ensure that we are using the latest version (which will use Node 16 instead of Node 12).

Please provide the steps to reproduce if possible:

  1. Navigate to Actions
  2. Select "Continuous Integration v2"
  3. Re-run the most recent scheduled run (This is only applicable to members with permissions)

Expected behaviour: We should no longer get a warning that Node 12 is deprecated and to upgrade. Other warnings may still occur and should be handled outside of this issue.

Please tell us about your environment:
N/A - GitHub Actions

mohzulfikar commented 1 year ago

Hello there, first time contributor here. After some research, the issue might be connected with this PR and this. We might have to wait until the testing was done in the upstream.

capnkenny commented 1 year ago

Hi there @mohzulfikar !

I don't believe we are using gha-setup-vsdevenv however we are certainly using humbletim's Vulkan SDK actions. With that said, we'll leave this as blocked for now. Thanks for the heads up!