Closed Pheubel closed 1 year ago
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It wraps the first argument of the logging function in fmt::runtime() to avoid issues with how FMT expects things in C++ 20
fmt::runtime()
Is there an open issue that this resolves? If so, please link it here.
It partially resolves https://github.com/novelrt/NovelRT/issues/500 (NovelRT/LoggingService).
What is the current behavior? (You can also link to an open issue here)
The logger builds on C++ 17, but fails to build on C++ 20.
What is the new behavior (if this is a feature change)?
The logger builds on C++ 17 and C++ 20.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
I don't think it causes any breakage
Other information:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It wraps the first argument of the logging function in
fmt::runtime()to avoid issues with how FMT expects things in C++ 20Is there an open issue that this resolves? If so, please link it here.
It partially resolves https://github.com/novelrt/NovelRT/issues/500 (NovelRT/LoggingService).
What is the current behavior? (You can also link to an open issue here)
The logger builds on C++ 17, but fails to build on C++ 20.
What is the new behavior (if this is a feature change)?
The logger builds on C++ 17 and C++ 20.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
I don't think it causes any breakage
Other information: