Open capnkenny opened 1 year ago
Hi there,
If I get it right, you need all the functions in the headers listed after the "#if defined(NOVELRT_C_API)" clause to be renamed?
For example: Nrt_getLastError to NrtGetLastError, or Nrt_AudioService_Create to NrtAudioServiceCreate?
Or does the Nrt_ prefix needs to be kept?
Hi,
Nrt_getLastError
would become Nrt_GetLastError
.
Thanks! As an additional input, should I create multiple pull requests as I rename sets of functions? For example, renaming the NrtErrorHandling API gives me 46 files modified for 362 changes on the project. What would be the easiest to review for you?
Describe the issue: C API currently has non-matching function name casing and should be updated so that the function names match our current code style.
The C API should match NovelRT's API and function names should be in PascalCase.
Please provide the steps to reproduce if possible: N/A - code styling issue
Additional context: Reference to code style issue where casing is incorrect.