Right now, in order to take advantage of C++ 20, you have to edit the cmake files and change target_compile_features(Engine PUBLIC cxx_std_17) to target_compile_features(Engine PUBLIC cxx_std_20) in src/NovelRT/CMakeList.txt and src/NovelRT.Interop/CMakeList.txt by hand.
What is the expected behaviour/change?
An option should be added to switch between compiling NovelRT with C++ 17 and C++ 20. Additionally, the current option to use std::span should be locked behind activating this option with cmake_dependent_option.
What is the motivation / use case for changing the behavior?
It is cumbersome to change between C++ versions and it can be easy to miss a target. It will also make testing scenarios easier to set up to test between different versions of NovelRT. Additionally, it allows developers to take advantage of NOVELRT_USE_STD_SPAN without having to alter the cmake list.
Describe alternatives you've considered:
An alternative would be to force a minimum version of C++ 20 onto developers, but this solution is not ideal.
Are there any potential roadblocks or challenges facing this change?
All be that there are no plans for it currently, we might want to add support for C++23 and other versions in the distant future. which might require more thought that a simple on off switch.
Are there any downsides to implementing this change?
There should not be any directly visible downsides to adding this change. Users that already adopted NOVELRT_USE_STD_SPAN, will have to restore their cmake and enable C++ 20 compilation if the dependent option is accepted as well.
What is the current behaviour?
Right now, in order to take advantage of C++ 20, you have to edit the cmake files and change
target_compile_features(Engine PUBLIC cxx_std_17)totarget_compile_features(Engine PUBLIC cxx_std_20)insrc/NovelRT/CMakeList.txtandsrc/NovelRT.Interop/CMakeList.txtby hand.What is the expected behaviour/change?
An option should be added to switch between compiling NovelRT with C++ 17 and C++ 20. Additionally, the current option to use
std::spanshould be locked behind activating this option with cmake_dependent_option.What is the motivation / use case for changing the behavior?
It is cumbersome to change between C++ versions and it can be easy to miss a target. It will also make testing scenarios easier to set up to test between different versions of NovelRT. Additionally, it allows developers to take advantage of
NOVELRT_USE_STD_SPANwithout having to alter the cmake list.Describe alternatives you've considered:
An alternative would be to force a minimum version of C++ 20 onto developers, but this solution is not ideal.
Are there any potential roadblocks or challenges facing this change?
All be that there are no plans for it currently, we might want to add support for C++23 and other versions in the distant future. which might require more thought that a simple on off switch.
Are there any downsides to implementing this change?
There should not be any directly visible downsides to adding this change. Users that already adopted
NOVELRT_USE_STD_SPAN, will have to restore their cmake and enable C++ 20 compilation if the dependent option is accepted as well.Additional context N/A