novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

Getting an error during the building process #567

Closed MichaelPCameron closed 1 year ago

MichaelPCameron commented 1 year ago

during the building process i am running into an error in CopyRuntimeDependencies.cmake file at line 18 and 85 getting this error: $

Expression did not evaluate to a known generator expression

RubyNova commented 1 year ago

Hey there, I appreciate the bug report - however without more information this is going to be hard to fix. Can you fill out the bug report template form with the appropriate information so I can begin taking a look? Thanks.

MichaelPCameron commented 1 year ago

Note: for support questions, please use the #engine-user-help channel in our Discord or create a discussion. This repository's issues are reserved for feature requests and bug reports.

Describe the issue: A clear and concise description of what the the current behaviour is.

Please provide the steps to reproduce if possible:

  1. Clone the repo
  2. setup files w/ the command prompt using CMake
  3. went over to visual studio and changed the installer root and the build root to what was provided
  4. calibrated
  5. See error
    • 16 errors at line 85 and 16 errors at line 18 saying that the expression did not evaluate known generator expression
    • having trouble with the target line

Expected behaviour: I expected for the build to finish and able to load up and check out the project

Please tell us about your environment:

Additional context: Add any other context about the problem here.

RubyNova commented 1 year ago

What version of CMake is this using? I think VS2019 might be shipping with a CMake version that's too old, and will require changing the settings. IIRC, we currently require CMake 3.21. It currently passes in our VS2019 CI, so I'm hoping it's just this.

MichaelPCameron commented 1 year ago

i have cmake 3.26

RubyNova commented 1 year ago

Is VS2019 currently using it? By default it won't.

MichaelPCameron commented 1 year ago

thats probably the problem what is the best way to change the default, thank you for helping me btw!

RubyNova commented 1 year ago

I believe it should be in your CMakeSettings.json, I forget precisely where as I mostly use VSCode and Neovim these days, but the value in the CMakeSettings.json that needs change is cmakeExecutable - I think VS2019 should have some UI to tweak this easier than typing raw strings though. It might be under the advanced CMake settings? Unsure.

MichaelPCameron commented 1 year ago

i switched over to 2022 and there isnt any errors but how do i run the program?

MichaelPCameron commented 1 year ago

i have the engine working now how do i utilize it?

Pheubel commented 1 year ago

Right now, the best place to look at are the sample applications. They show you how to set up an executable that makes use of the engine in various ways.

But i think the problem for this issue has been resolved.

RubyNova commented 1 year ago

LGTM, closing.