novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

Part 1 of Core refactoring - Core Namespace #573

Closed capnkenny closed 1 year ago

capnkenny commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Begins to address the namespace and engine refactoring as briefly mentioned in #423

Is there an open issue that this resolves? If so, please link it here.

423

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Items in the core namespace (built by the NovelRT_Core target) will be linked directly in via the Engine target. This also begins to remove dependencies on NovelRT.h

Other information: One of many steps - this one was for the base implementation (and figuring out how to do it) - additional CMake changes will come later on once the namespaces begin to shape up (i.e. target OS detection, etc)

capnkenny commented 1 year ago

Closing, as we have discussed changing our approach at a later date (for now, MVP and splitting platform deps is going to be the main route).