novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

Fix Sparse data shrinkage bug. #584

Closed RubyNova closed 1 year ago

RubyNova commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This removes a workaround that was recently introduced to SparseSetMemoryContainer::ContainsKey and replaces it with the actual fix to the issue.

Is there an open issue that this resolves? If so, please link it here. No.

What is the current behavior? (You can also link to an open issue here) The unit tests pass and sparse set works as intended, with the memory usage shrinking correctly.

What is the new behavior (if this is a feature change)? Ditto.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No.

Other information: N/A