novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
185 stars 42 forks source link

Simplify Atom to using typedef. #585

Closed RubyNova closed 1 year ago

RubyNova commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This simplifies the atom type to a simple using style typedef, which should fix ambigious API usage issues we were having previously.

Is there an open issue that this resolves? If so, please link it here. No.

What is the current behavior? (You can also link to an open issue here) Atom is a class.

What is the new behavior (if this is a feature change)? Atom is a using typedef.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Yes. The AtomHashFunction and the std namespace template overload associated with it no longer exists.

Other information: N/A