novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

[GHA] Clang-format does not seem to agree with local clang-format. #586

Open RubyNova opened 1 year ago

RubyNova commented 1 year ago

Note: for support questions, please use the #engine-user-help channel in our Discord or create a discussion. This repository's issues are reserved for feature requests and bug reports.

Describe the issue: The clang-format being used by CI seems to output a different result from the clang-format installation I have on Windows 10, meaning I have to apply the CI patch regardless. This indicates to me something is potentially broken on CI.

Please provide the steps to reproduce if possible:

  1. Clone the repo
  2. Install clang-format on Windows 10
  3. run clang-format
  4. push up
  5. open a PR
  6. Observe the issue

Expected behaviour: Clang-format should do the same modifications regardless of platform.

Please tell us about your environment:

Additional context: It could be that there's additional flags I need to pass to Clang-Format locally I am unaware of, but just in case, I felt I should log an issue for the CI pipelines.