novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
184 stars 42 forks source link

Revamp Input to reintroduce KeyStateFrameChangeLog #591

Closed capnkenny closed 10 months ago

capnkenny commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Modifies the Input low-level systems to use GLFW's callbacks instead of polling. Also re-adds the frame changelog functionality from the legacy InteractionService to work with our "Mapped Actions".

capnkenny commented 11 months ago

I will note that as per our header includes, we're to begin moving away from the all-inclusive header - i.e. "Input.hpp" - however we haven't actually done that yet (such as with Graphics and Audio), and I rather keep this PR from hitting a larger amount of scope growth I have proven myself to be a liar :( but the dark deed is done and the centralised header is no more

github-actions[bot] commented 11 months ago

Test Results

       4 files         4 suites   1m 31s :stopwatch:    693 tests    693 :heavy_check_mark: 0 :zzz: 0 :x: 2 772 runs  2 772 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit b68dddaa.