novelrt / NovelRT

A cross-platform 2D game engine accompanied by a strong toolset for visual novels.
MIT License
183 stars 43 forks source link

Fix spdlog issue and numerous GHActions deprecation warnings #601

Closed capnkenny closed 1 month ago

capnkenny commented 3 months ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fixes a build error induced by spdlog and newer versions of MSVC, and resolves some GH Actions warnings about node12/node16 deprecation.

Is there an open issue that this resolves? If so, please link it here. Fixes #600

What is the current behavior? (You can also link to an open issue here) Builds fail when attempting to compile NovelRT-Graphics due to iterator usage from spdlog that is deprecated - this is due to older fmt builds built into spdlog that use the old behavior.

github-actions[bot] commented 3 months ago

Test Results

    7 files  +    3      7 suites  +3   2m 57s :stopwatch: + 1m 56s   693 tests ±    0    693 :white_check_mark: ±    0  0 :zzz: ±0  0 :x: ±0  4 851 runs  +2 079  4 851 :white_check_mark: +2 079  0 :zzz: ±0  0 :x: ±0 

Results for commit acd8c98f. ± Comparison against base commit abbc1f9b.

:recycle: This comment has been updated with latest results.