Clean-up and "When you disard this from play" effects

[GoogleCodeExporter]

I've noticed a couple problems with Clean-up phase and certain "When you 
discard this from play" (DFP) effects.

Let me list all the DFP effecs:
Alchemist - if a potion is in play, top deck this
Herbalist - top deck a chosen treasure in play
Treasury - if didn't buy a victory card, top deck this
Hermit - if you didn't buy anything, trash this and gain a madman

Scheme - Technically this is an "At the beginning of clean-up" effect, that 
gives a chosen action card in play a DFP effect to top deck the chosen card.  
But Androminion treats it like a "When you discard Scheme, top deck an action 
in play" effect.

Because of this Scheme isn't working correctly with certain other DFP effects.  
This doesn't really matter with Alchemist and Treasury since their effects are 
identical (top deck the card).  But for Herbalist and Hermit the effect is not 
the same and thus the problem.

At the beginning of clean-up, for each scheme you played, you are supposed to 
be able to choose any action card in play (or choose none).  When that chosen 
card is discarded, it is to be put on your deck.  If that card has DFP effects 
they should fire because it is being discarded to trigger the Scheme effect.  
But instead when you choose to top deck an action card with Scheme, the chosen 
card is removed from play without triggering its own discard from play effects.

For example, in play:
Scheme
Herbalist
treasure(s)

At the beginning of clean-up, before you discard anything, you should be able 
to choose Herbalist to be top decked when discarded.  Then, when it is 
discarded both events should fire, one to top deck it and one to top deck a 
treasure and you should be given the choice of their order.  This will allow 
you to choose whether Herbalist or the chosen treasure ends up on top of the 
other.

Instead Androminion gives you these options:
Action card (scheme)
Treasure card (herbalist)
None

If you choose to top deck an action card and then choose herbalist, you will 
not get a chance to top deck a treasure.  If you choose to top deck a treasure 
and then try to top deck an action, herbalist won't be an option because it has 
already been discarded.

Another example, in play:
Scheme
Hermit
(Nothing was bought this turn)

At the beginning of clean-up, you should be given the choice of which (if any) 
action to top deck when discarded.  If you choose Hermit, when you discard it 
both effects should fire and you should be given the choice of their order.  If 
you choose to resolve Hermit first, it will be trashed and Scheme's effect will 
"lose track" of it and do nothing.  But if you choose Scheme's effect first 
Hermit should be top decked and Hermit's effect will "loose track" and fail to 
trash it but you should still gain a madman since the effect doesn't say "if 
you do" after telling you to trash it.

But on Androminion if you choose to top deck Hermit with Scheme it will not do 
any of its discard effect, so no Madman is gained.  The FAQ that comes with 
Dark Ages actually implies that Scheme can't do this.  But this is not the case 
if you read the card text plainly.  Even Donald X has admitted the FAQ is 
incorrect in using Scheme in its example. The post on 
forum.dominionstrategy.com:
http://forum.dominionstrategy.com/index.php?topic=6374.msg171261#msg171261

The other issue with DFP top deck effects is the way Androminion handles their 
ordering.  It asks you one at a time which cards you want to top deck, and then 
after you are done it asks you to order them.  But ordering them isn't part of 
the effect.  The order you discard them is the order they're put on the top of 
the deck, with the last being on top. The reason this causes problems is with 
Alchemist and Herbalist.

Example:
Alchemist
Herbalist
Potion (just one)

Androminion lets you choose to top deck:
Alchemist
Treasure card (Herbalist)

If you choose to top deck the potion before the Alchemist, you won't be given 
the option to top deck them anymore that turn.  And that is correct.  So you 
top deck the Alchemist and then the Potion.  And then Androminion asks you to 
order the top of the deck.  But it is impossible to put the Alchemist on top of 
the potion because if the potion was put on top first, there wouldn't be a 
potion in play for the effect to trigger on.

The only time you should be ordering the top of the deck from DFP effects is 
when Scheme is top decking an Herbalist and thus two cards are being put on top 
of the deck at the same time.  Otherwise, the cards should be put on top in the 
order they're chosen to be discarded.

Original issue reported on code.google.com by EnergySu...@gmail.com on 17 Feb 2013 at 4:19

[GoogleCodeExporter]

First of all, this is a really good issue report for a valid issue.

Secondly, I've marked this low priority for now because there are very very few 
real gameplay situations that will be affected by this issue (except Scheme / 
Hermit, which issue 548 targets specifically) since most of the time, you'll 
just draw all the cards you put on top of your deck at the end of your turn.  

Original comment by August.D...@gmail.com on 26 Feb 2013 at 6:54

• Changed state: Accepted
• Added labels: Component-Core, Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

>most of the time, you'll just draw all the cards

Alchemist/Herbalist/Potion is a pretty common exception in cases where opponent 
is playing trashing attacks. Patrick in particular is fond of both Saboteur and 
Rogue.

Original comment by wesc...@gmail.com on 26 Feb 2013 at 7:12