search

novid20org / novid20-android-sdk

NOVID20 Android SDK Source Code
https://novid20.org
GNU General Public License v3.0
36 stars 3 forks source link

onboarded vs. registered, onboarded never set #10

Open michaelroland opened 4 years ago

michaelroland commented 4 years ago

config.onboarded is required to be true in order for the automatic discovery to start. However, that configuration value is never set by the SDK and the default/initial value is false.

Is this meant to be set from the app implementation?

What is the difference between config.onboarded and config.registered? The latter is set once a user was successfully registered. Were these meant to be the same thing?

myfknoll commented 4 years ago

Well, basically the onboarding config is set after the onboarding of the app itself. We wanted to avoid that we start the whole thing before the user accepted the terms of use.

Registration is the part where you actually got an nov20 id from the backend.

michaelroland commented 4 years ago

Ack, shouldn't the SDK then provide a method that allows the app to confirm completion of the onboarding to store that in the shared pref?

myfknoll commented 4 years ago

Well, the onboarded field in the config is public, so basicallly the app can set it anytime. val novidSdk = NovidSdk.getInstance() novidSdk.getConfig().onboarded = true

May not be the best API for that, but we were quite limited with time 😄