UID vs. user ID mismatch

[michaelroland]

On NovidSdkImpl.kt:132, the config.uid value is read, and, if empty, config.userId is updated to a newly generated UUID.

It is unclear what this code is actually supposed to do for the following reasons:

• Certainly, the same value was meant to be tested for being empty and later initialization to a random value, so either config.uid or config.userId.
• The user ID is provided by the server upon registration. Hence, this code could be meant to initialize the user ID when not yet registered. However, no tracing should happen in that case anyways and the UUID does not match the expected user ID format (prefix nov20-).
• The UID is provided by the app implementation upon user registration. Hence, this code could also be meant to initialize the UID when not yet registered.

[myfknoll]

Thank you for your feedback.

Well we have removed the fake userId generation, and added now a kind of onboarding workflow in the app code, where the user needs to be online to "register" in order to get this public userid.

If there is no stored userId in the config, the SDK will not be able to start, see also NovidSdkImpl.kt:256